Assertions in PS/2 driver

This commit is contained in:
Jeremy Soller 2016-09-01 21:01:38 -06:00
parent 3d79c653bd
commit 7a4c5de2ae

View file

@ -199,37 +199,30 @@ impl Ps2 {
// Perform the self test // Perform the self test
self.command(Command::TestController); self.command(Command::TestController);
let self_test = self.read(); assert_eq!(self.read(), 0x55);
if self_test != 0x55 {
// TODO: Do reset on failure
print!("PS/2 Self Test Failure: {:X}\n", self_test);
return;
}
// Enable devices // Enable devices
self.command(Command::EnableFirst); self.command(Command::EnableFirst);
self.command(Command::EnableSecond); self.command(Command::EnableSecond);
// Reset and enable scanning on keyboard // Reset and enable scanning on keyboard
// TODO: Check for ack assert_eq!(self.keyboard_command(KeyboardCommand::Reset), 0xFA);
print!("KEYBOARD RESET {:X}\n", self.keyboard_command(KeyboardCommand::Reset)); assert_eq!(self.read(), 0xAA);
print!("KEYBOARD RESET RESULT {:X} == 0xAA\n", self.read());
self.flush_read(); self.flush_read();
// Reset and enable scanning on mouse // Reset and enable scanning on mouse
// TODO: Check for ack // TODO: Check for ack
print!("MOUSE RESET {:X}\n", self.mouse_command(MouseCommand::Reset)); assert_eq!(self.mouse_command(MouseCommand::Reset), 0xFA);
print!("MOUSE RESET RESULT {:X} == 0xAA\n", self.read()); assert_eq!(self.read(), 0xAA);
print!("MOUSE RESET ID {:X} == 0x00\n", self.read()); assert_eq!(self.read(), 0x00);
self.flush_read(); self.flush_read();
// Enable extra packet on mouse // Enable extra packet on mouse
print!("SAMPLE 200 {:X}\n", self.mouse_command_data(MouseCommandData::SetSampleRate, 200)); assert_eq!(self.mouse_command_data(MouseCommandData::SetSampleRate, 200), 0xFA);
print!("SAMPLE 100 {:X}\n", self.mouse_command_data(MouseCommandData::SetSampleRate, 100)); assert_eq!(self.mouse_command_data(MouseCommandData::SetSampleRate, 100), 0xFA);
print!("SAMPLE 80 {:X}\n", self.mouse_command_data(MouseCommandData::SetSampleRate, 80)); assert_eq!(self.mouse_command_data(MouseCommandData::SetSampleRate, 80), 0xFA);
print!("GET ID {:X}\n", self.mouse_command(MouseCommand::GetDeviceId)); assert_eq!(self.mouse_command(MouseCommand::GetDeviceId), 0xFA);
let mouse_id = self.read(); let mouse_id = self.read();
print!("MOUSE ID: {:X} == 0x03\n", mouse_id);
self.mouse_extra = mouse_id == 3; self.mouse_extra = mouse_id == 3;
// Enable extra buttons, TODO // Enable extra buttons, TODO
@ -245,11 +238,11 @@ impl Ps2 {
*/ */
// Set sample rate to maximum // Set sample rate to maximum
print!("SAMPLE 200 {:X}\n", self.mouse_command_data(MouseCommandData::SetSampleRate, 200)); assert_eq!(self.mouse_command_data(MouseCommandData::SetSampleRate, 200), 0xFA);
// Enable data reporting // Enable data reporting
print!("KEYBOARD ENABLE {:X}\n", self.keyboard_command(KeyboardCommand::EnableReporting)); assert_eq!(self.keyboard_command(KeyboardCommand::EnableReporting), 0xFA);
print!("MOUSE ENABLE {:X}\n", self.mouse_command(MouseCommand::EnableReporting)); assert_eq!(self.mouse_command(MouseCommand::EnableReporting), 0xFA);
// Enable clocks and interrupts // Enable clocks and interrupts
{ {
@ -275,6 +268,9 @@ impl Ps2 {
let flags = MousePacketFlags::from_bits_truncate(self.mouse[0]); let flags = MousePacketFlags::from_bits_truncate(self.mouse[0]);
assert!(flags.contains(ALWAYS_ON));
if ! flags.contains(X_OVERFLOW) && ! flags.contains(Y_OVERFLOW) {
let mut dx = self.mouse[1] as isize; let mut dx = self.mouse[1] as isize;
if flags.contains(X_SIGN) { if flags.contains(X_SIGN) {
dx -= 0x100; dx -= 0x100;
@ -302,3 +298,4 @@ impl Ps2 {
} }
} }
} }
}