better split of home manager specific stuff

modules/users/default.nix

@@ -19,55 +19,6 @@ in {
       ./ronja.nix
     ]
     ++ lib.optionals enableHomeManager [
-      <home-manager/nixos>
+      ./home-manager.nix
     ];
-
-  config = lib.mkIf enableHomeManager {
-    home-manager = {
-      useUserPackages = true;
-      useGlobalPkgs = true;
-      sharedModules = [
-        # set stateVersion
-        {home.stateVersion = "22.11";}
-        # make nano the default editor
-        {
-          home = {
-            sessionVariables.EDITOR = "nano";
-            file.".nanorc".text = lib.mkDefault ''
-              set linenumbers
-              set mouse
-            '';
-          };
-        }
-        # command line niceness
-        {
-          programs = {
-            command-not-found.enable = true;
-            dircolors.enable = true;
-
-            zsh = {
-              enable = true;
-              enableSyntaxHighlighting = true;
-              enableAutosuggestions = true;
-              enableVteIntegration = true;
-            };
-          };
-        }
-        # common git config
-        {
-          programs = {
-            git = {
-              enable = true;
-              extraConfig.init.defaultBranch = "main";
-            };
-
-            gh = {
-              enable = true;
-              enableGitCredentialHelper = true;
-            };
-          };
-        }
-      ];
-    };
-  };
 }

modules/users/home-manager.nix

@@ -0,0 +1,65 @@
+{
+  config,
+  pkgs,
+  lib,
+  ...
+}: {
+  imports = [
+    <home-manager/nixos>
+  ];
+
+  config = {
+    home-manager = {
+      useUserPackages = true;
+      useGlobalPkgs = true;
+
+      users = {
+        ronja = lib.mkIf (builtins.elem "ronja" config.my.enabledUsers) (import ./ronja-home.nix);
+        vinzenz = lib.mkIf (builtins.elem "ronja" config.my.enabledUsers) (import ./vinzenz-home.nix);
+      };
+
+      sharedModules = [
+        # set stateVersion
+        {home.stateVersion = "22.11";}
+        # make nano the default editor
+        {
+          home = {
+            sessionVariables.EDITOR = "nano";
+            file.".nanorc".text = lib.mkDefault ''
+              set linenumbers
+              set mouse
+            '';
+          };
+        }
+        # command line niceness
+        {
+          programs = {
+            command-not-found.enable = true;
+            dircolors.enable = true;
+
+            zsh = {
+              enable = true;
+              enableSyntaxHighlighting = true;
+              enableAutosuggestions = true;
+              enableVteIntegration = true;
+            };
+          };
+        }
+        # common git config
+        {
+          programs = {
+            git = {
+              enable = true;
+              extraConfig.init.defaultBranch = "main";
+            };
+
+            gh = {
+              enable = true;
+              enableGitCredentialHelper = true;
+            };
+          };
+        }
+      ];
+    };
+  };
+}

modules/users/ronja.nix

@@ -6,8 +6,7 @@
 }: let
   isUserEnabled = builtins.elem "ronja" config.my.enabledUsers;
 in {
-  config = lib.mkMerge [
-    (lib.mkIf isUserEnabled {
+  config = lib.mkIf isUserEnabled {
     # Define user account
     users.users.ronja = {
       isNormalUser = true;
@@ -17,9 +16,5 @@ in {
       extraGroups = ["networkmanager" "wheel" "games"];
       shell = pkgs.zsh;
     };
-    })
-    (lib.mkIf (isUserEnabled && config.my.modulesCfg.enableHomeManager) {
-      home-manager.users.ronja = import ./ronja-home.nix;
-    })
-  ];
+  };
 }

modules/users/vinzenz.nix

@@ -6,8 +6,7 @@
 }: let
   isUserEnabled = builtins.elem "vinzenz" config.my.enabledUsers;
 in {
-  config = lib.mkMerge [
-    (lib.mkIf isUserEnabled {
+  config = lib.mkIf isUserEnabled {
     users.users.vinzenz = {
       isNormalUser = true;
       name = "vinzenz";
@@ -16,9 +15,5 @@ in {
       extraGroups = ["networkmanager" "wheel" "games"];
       shell = pkgs.zsh;
     };
-    })
-    (lib.mkIf (isUserEnabled && config.my.modulesCfg.enableHomeManager) {
-      home-manager.users.vinzenz = import ./vinzenz-home.nix;
-    })
-  ];
+  };
 }