Watch
0
0
Fork
You've already forked hyperhive
0
hyperhive/swarm-secret-client/src
Repository files (latest commit first)
Filename Latest commit message Latest commit date
atlas a669cd96b6 swarm-controller: post the review classifier's verdict on a review request
Requesting the forge account `review-classifier` as a reviewer now runs the
repo's rules against the PR and posts the result as that account's review,
on the head commit the run read. A push starts no run; only a fresh review
request does.

- An instance-wide `pull_request_review_request` system hook delivers to
  `/webhook/forge/review-request`. A request for any other reviewer, or a
  removed request, does nothing.
- The controller reads the PR, loads the rules with the same reader as
  `GET /api/review-classifier/rules`, sends one request on the try-out
  subject, and posts APPROVED or REQUEST_CHANGES with the table as the body.
- With no clean verdict (PR or rules don't load, the run fails, or any
  classification has no answer) it posts a COMMENT saying why, never an
  approval. The event is one function, `no_clean_verdict_event`.
- Table cells are flattened, markup-escaped, and every `@` gets a
  zero-width space, so a model's reason can't break the table or mention
  anyone.
- At most two requested reviews run at once; the rest wait in memory.
- The account is minted the way hive accounts are: a five-minute pass
  queues a `MintClassifierForgeToken` node when the token at
  `swarm/services/review-classifier/forge/token` is missing or stale. The
  token is `write:repository`. The controller's bao policy gains that leaf
  (create/read/update), pinned in module-eval bao-grants. The classifier
  never sees the token.

The account gets no repo access automatically; a repo admin adds it by
hand. A re-request retires the account's earlier review: Forgejo clears
`official` on a reviewer's earlier reviews when it is requested again
(models/issues/review.go AddReviewRequest, v16.0.5), and approvals and
rejection blocks count official reviews only.

Refs #5137
2026-10-12 16:11:50 +02:00
..
acp.rs hive-runtime: read the ACP provider key from bao 2026-09-30 22:55:03 +02:00
ci.rs swarm-ci-runner: run the forge CI runner as a swarm service 2026-10-05 13:55:37 +02:00
client.rs swarm-secret-client: bound vault requests with a 30s timeout 2026-10-09 15:11:38 +02:00
forge.rs swarm-controller reads its forge token from the store, not a host file 2026-10-08 13:25:47 +02:00
github.rs github swarm bao: address argus review on #4892 2026-10-02 17:54:45 +02:00
lib.rs swarm-review-classifier: answer a try-out with one claude run per classification 2026-10-12 13:11:21 +02:00
matrix.rs matrix: drop the per-hive appservice and its unused token 2026-10-05 07:48:17 +02:00
mtls.rs agents: re-pull the agent's own bao mTLS leaf on a timer 2026-10-11 10:00:43 +02:00
path.rs swarm-ci-runner: run the forge CI runner as a swarm service 2026-10-05 13:55:37 +02:00
policy.rs swarm-secret-client: hives no longer read swarm/services/* 2026-10-04 23:11:11 +02:00
queue.rs hive status publishing: read the hive's OIDC secret from the store, retry until it is there 2026-10-10 01:05:33 +02:00
review_classifier.rs swarm-controller: post the review classifier's verdict on a review request 2026-10-12 16:11:50 +02:00