vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Activity

dashboard: log a warning when tombstone purge fails to fail pending approvals

Browse source 
post_purge_tombstone discarded fail_pending_for_agent's error with
let _ =. Mirrors #4740's fix for the identical discard in
job_queue/exec.rs's run_destroy_bookkeeping: warn and continue, since
the purge itself has already succeeded by this point.

Refs #4747
This commit is contained in:
atlas 2026-09-28 23:51:04 +02:00 • committed by mara
commit f7437a4773
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
hive-c0re/src/dashboard/tombstones.rs
View file

@ -189,10 +189,13 @@ pub(super) async fn post_purge_tombstone(
errors.push(format!("{}: {e}", dir.display())); errors.push(format!("{}: {e}", dir.display()));
} }
} }
let _ = state if let Err(e) = state
.coord .coord
.approvals .approvals
.fail_pending_for_agent(name.as_str(), "agent state purged"); .fail_pending_for_agent(name.as_str(), "agent state purged")
{
tracing::warn!(%name, error = ?e, "approvals: failing pending on tombstone purge failed");
}
if errors.is_empty() { if errors.is_empty() {
tracing::info!(%name, "tombstone purged"); tracing::info!(%name, "tombstone purged");
// Fire the post-purge tombstones snapshot so dashboards // Fire the post-purge tombstones snapshot so dashboards