From f7437a4773f89ae46e613d863cce7faaeece5696 Mon Sep 17 00:00:00 2001 From: atlas Date: Mon, 28 Sep 2026 23:51:04 +0200 Subject: [PATCH] dashboard: log a warning when tombstone purge fails to fail pending approvals post_purge_tombstone discarded fail_pending_for_agent's error with let _ =. Mirrors #4740's fix for the identical discard in job_queue/exec.rs's run_destroy_bookkeeping: warn and continue, since the purge itself has already succeeded by this point. Refs #4747 --- hive-c0re/src/dashboard/tombstones.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hive-c0re/src/dashboard/tombstones.rs b/hive-c0re/src/dashboard/tombstones.rs index eebf7c49..365496ba 100644 --- a/hive-c0re/src/dashboard/tombstones.rs +++ b/hive-c0re/src/dashboard/tombstones.rs @@ -189,10 +189,13 @@ pub(super) async fn post_purge_tombstone( errors.push(format!("{}: {e}", dir.display())); } } - let _ = state + if let Err(e) = state .coord .approvals - .fail_pending_for_agent(name.as_str(), "agent state purged"); + .fail_pending_for_agent(name.as_str(), "agent state purged") + { + tracing::warn!(%name, error = ?e, "approvals: failing pending on tombstone purge failed"); + } if errors.is_empty() { tracing::info!(%name, "tombstone purged"); // Fire the post-purge tombstones snapshot so dashboards