Watch
0
0
Fork
You've already forked hyperhive
0

review-classifier: docs-updated is not applicable when nothing operator-visible changes

This commit is contained in:
atlas 2026-10-18 11:49:30 +02:00 • committed by mara
commit bff13c8c68
2 changed files with 11 additions and 5 deletions

View file

@ -60,7 +60,11 @@ classifications:
a service does for operators across hosts, such as what it scrapes,
serves or publishes: that needs a docs/ page or README. A nix option
declared `internal = true` or `visible = false` is not something an
operator sees, so adding or changing one needs none of these.
operator sees, so adding or changing one needs none of these. A diff
that changes nothing an operator or user sees makes the question not
applicable: a pure internal refactor, a move between modules or
crates, a rename of private items, or an edit to comments and doc
comments.
polarity: positive
threshold: 65
- name: one-purpose

View file

@ -60,10 +60,12 @@ classifications:
threshold: 70
- name: docs-updated
description: >-
The PR updates the operator-facing docs where the code change
needs it.
A change to what an operator or user sees, such as a command, flag,
option, endpoint, service or default, updates the matching page under
docs/ or the crate's README in the same diff. A diff that changes
nothing an operator or user sees makes the question not applicable.
polarity: positive
threshold: 60
threshold: 65
```
## Trigger and lifecycle
@ -386,7 +388,7 @@ changes, and the table is the review's body. An illustrative table:
| ❌ no match | datetime | 92 / 80 | Two new timestamps use naive datetimes. |
| ✅ no match | no-ads | 99 / 90 | No commit message carries an AI attribution. |
| ❔ unsure | bao-first | 95 / 70 | The PR adds no secret. |
| ❔ match | docs-updated | 41 / 60 | Below threshold. |
| ❔ match | docs-updated | 41 / 65 | Below threshold. |
**Overall: ❌ request changes**