From bff13c8c68e2241b92e93ca67a959aef7709639a Mon Sep 17 00:00:00 2001 From: atlas Date: Sun, 18 Oct 2026 11:49:30 +0200 Subject: [PATCH] review-classifier: docs-updated is not applicable when nothing operator-visible changes --- .hyperhive/review-classifier.yml | 6 +++++- docs/swarm/review-classifier.md | 10 ++++++---- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/.hyperhive/review-classifier.yml b/.hyperhive/review-classifier.yml index 74667a1b..90e6af9c 100644 --- a/.hyperhive/review-classifier.yml +++ b/.hyperhive/review-classifier.yml @@ -60,7 +60,11 @@ classifications: a service does for operators across hosts, such as what it scrapes, serves or publishes: that needs a docs/ page or README. A nix option declared `internal = true` or `visible = false` is not something an - operator sees, so adding or changing one needs none of these. + operator sees, so adding or changing one needs none of these. A diff + that changes nothing an operator or user sees makes the question not + applicable: a pure internal refactor, a move between modules or + crates, a rename of private items, or an edit to comments and doc + comments. polarity: positive threshold: 65 - name: one-purpose diff --git a/docs/swarm/review-classifier.md b/docs/swarm/review-classifier.md index f2d1e1ca..23a47081 100644 --- a/docs/swarm/review-classifier.md +++ b/docs/swarm/review-classifier.md @@ -60,10 +60,12 @@ classifications: threshold: 70 - name: docs-updated description: >- - The PR updates the operator-facing docs where the code change - needs it. + A change to what an operator or user sees, such as a command, flag, + option, endpoint, service or default, updates the matching page under + docs/ or the crate's README in the same diff. A diff that changes + nothing an operator or user sees makes the question not applicable. polarity: positive - threshold: 60 + threshold: 65 ``` ## Trigger and lifecycle @@ -386,7 +388,7 @@ changes, and the table is the review's body. An illustrative table: | ❌ no match | datetime | 92 / 80 | Two new timestamps use naive datetimes. | | ✅ no match | no-ads | 99 / 90 | No commit message carries an AI attribution. | | ❔ unsure | bao-first | 95 / 70 | The PR adds no secret. | -| ❔ match | docs-updated | 41 / 60 | Below threshold. | +| ❔ match | docs-updated | 41 / 65 | Below threshold. | **Overall: ❌ request changes**