vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Activity

hive-forge: format the assign-reviewer test and document the --remove failure

Browse source
This commit is contained in:
damocles 2026-10-26 17:16:40 +01:00 • committed by mara
commit 7c10b79677
2 changed files with 14 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/tools/forge.md
View file

@ -82,7 +82,7 @@ hive-forge pr reviews 42 --approve # submit APPROVED review
hive-forge pr reviews 42 --request-changes -m "msg" # submit REQUEST_CHANGES review hive-forge pr reviews 42 --request-changes -m "msg" # submit REQUEST_CHANGES review
hive-forge pr reviews 42 --comment -m "msg" # submit COMMENT review hive-forge pr reviews 42 --comment -m "msg" # submit COMMENT review
hive-forge pr assign-reviewer 42 argus # set argus as a requested reviewer on the PR hive-forge pr assign-reviewer 42 argus # set argus as a requested reviewer on the PR
hive-forge pr assign-reviewer 42 argus --remove # withdraw the request hive-forge pr assign-reviewer 42 argus --remove # withdraw the request; fails if argus is still listed afterwards (a reviewer who already reviewed stays listed)
hive-forge pr assign-committer 42 damocles # add damocles to the PR's assignee list hive-forge pr assign-committer 42 damocles # add damocles to the PR's assignee list
hive-forge pr diff 42 # unified diff (lockfile hunks collapsed by default) hive-forge pr diff 42 # unified diff (lockfile hunks collapsed by default)
hive-forge pr diff 42 --full # include unfiltered lockfile hunks hive-forge pr diff 42 --full # include unfiltered lockfile hunks

15
hive-forge/tests/pr_assign_reviewer.rs
View file

@ -76,7 +76,15 @@ fn remove_argus(tag: &str, requested: &'static [&'static str]) -> (bool, String,
} }
}); });
let out = Command::new(env!("CARGO_BIN_EXE_hive-forge")) let out = Command::new(env!("CARGO_BIN_EXE_hive-forge"))
.args(["-r", "o/r", "pr", "assign-reviewer", "7", "argus", "--remove"]) .args([
"-r",
"o/r",
"pr",
"assign-reviewer",
"7",
"argus",
"--remove",
])
.env("HIVE_FORGE_URL", format!("http://{addr}")) .env("HIVE_FORGE_URL", format!("http://{addr}"))
.env("HYPERHIVE_STATE_DIR", scratch_state_dir(tag)) .env("HYPERHIVE_STATE_DIR", scratch_state_dir(tag))
.env_remove("HIVE_FORGE_TOKEN_FILE") .env_remove("HIVE_FORGE_TOKEN_FILE")
@ -102,5 +110,8 @@ fn withdrawal_that_left_the_reviewer_listed_is_reported_as_failed() {
fn withdrawal_that_removed_the_reviewer_is_reported_as_done() { fn withdrawal_that_removed_the_reviewer_is_reported_as_done() {
let (ok, stdout, stderr) = remove_argus("removed", &["review-classifier"]); let (ok, stdout, stderr) = remove_argus("removed", &["review-classifier"]);
assert!(ok, "{stderr}"); assert!(ok, "{stderr}");
assert!(stdout.contains("review request withdrawn: argus on #7"), "{stdout}"); assert!(
stdout.contains("review request withdrawn: argus on #7"),
"{stdout}"
);
} }