From 7c10b7967727e8f0feb2d7239d6d5550442197cb Mon Sep 17 00:00:00 2001
From: damocles <damocles@hyperhive.local>
Date: Mon, 26 Oct 2026 17:16:40 +0100
Subject: [PATCH] hive-forge: format the assign-reviewer test and document the
 --remove failure

---
 docs/tools/forge.md                    |  2 +-
 hive-forge/tests/pr_assign_reviewer.rs | 15 +++++++++++++--
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/docs/tools/forge.md b/docs/tools/forge.md
index aa87d698..3e2d8cae 100644
--- a/docs/tools/forge.md
+++ b/docs/tools/forge.md
@@ -82,7 +82,7 @@ hive-forge pr reviews 42 --approve         # submit APPROVED review
 hive-forge pr reviews 42 --request-changes -m "msg"  # submit REQUEST_CHANGES review
 hive-forge pr reviews 42 --comment -m "msg"  # submit COMMENT review
 hive-forge pr assign-reviewer 42 argus      # set argus as a requested reviewer on the PR
-hive-forge pr assign-reviewer 42 argus --remove  # withdraw the request
+hive-forge pr assign-reviewer 42 argus --remove  # withdraw the request; fails if argus is still listed afterwards (a reviewer who already reviewed stays listed)
 hive-forge pr assign-committer 42 damocles  # add damocles to the PR's assignee list
 hive-forge pr diff 42                       # unified diff (lockfile hunks collapsed by default)
 hive-forge pr diff 42 --full                # include unfiltered lockfile hunks
diff --git a/hive-forge/tests/pr_assign_reviewer.rs b/hive-forge/tests/pr_assign_reviewer.rs
index cac3f19a..69d7ef6f 100644
--- a/hive-forge/tests/pr_assign_reviewer.rs
+++ b/hive-forge/tests/pr_assign_reviewer.rs
@@ -76,7 +76,15 @@ fn remove_argus(tag: &str, requested: &'static [&'static str]) -> (bool, String,
         }
     });
     let out = Command::new(env!("CARGO_BIN_EXE_hive-forge"))
-        .args(["-r", "o/r", "pr", "assign-reviewer", "7", "argus", "--remove"])
+        .args([
+            "-r",
+            "o/r",
+            "pr",
+            "assign-reviewer",
+            "7",
+            "argus",
+            "--remove",
+        ])
         .env("HIVE_FORGE_URL", format!("http://{addr}"))
         .env("HYPERHIVE_STATE_DIR", scratch_state_dir(tag))
         .env_remove("HIVE_FORGE_TOKEN_FILE")
@@ -102,5 +110,8 @@ fn withdrawal_that_left_the_reviewer_listed_is_reported_as_failed() {
 fn withdrawal_that_removed_the_reviewer_is_reported_as_done() {
     let (ok, stdout, stderr) = remove_argus("removed", &["review-classifier"]);
     assert!(ok, "{stderr}");
-    assert!(stdout.contains("review request withdrawn: argus on #7"), "{stdout}");
+    assert!(
+        stdout.contains("review request withdrawn: argus on #7"),
+        "{stdout}"
+    );
 }