vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fixup: update stale CreateAgentPage cross-references (argus review)

Browse source 
Three doc comments elsewhere in the tree still named the old
CreateAgentPage identifier/page framing after the rename in this
branch -- TextField.tsx, Panel.tsx, FormField.css (x3). None of these
files are touched by the rest of the diff, which is exactly how the
staleness happened.
This commit is contained in:
iris 2026-08-24 00:34:34 +02:00
commit 4fd6480c9c
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
frontend/packages/swarm-ui/src/ui/form-field/FormField.css
View file

@ -3,7 +3,7 @@
from (one class, so the two never drift). `width: 100%` fills from (one class, so the two never drift). `width: 100%` fills
whichever container the caller gives it — the kit itself has no whichever container the caller gives it — the kit itself has no
opinion on a maximum width; a page that wants one narrower than its opinion on a maximum width; a page that wants one narrower than its
own layout caps it at the layout level (`CreateAgentPage.css`'s own layout caps it at the layout level (`CreateAgentForm.css`'s
`.create-agent-form-col` is the existing example), same reasoning `.create-agent-form-col` is the existing example), same reasoning
`Panel` has no width opinion of its own either. `min-height` is a `Panel` has no width opinion of its own either. `min-height` is a
touch-target floor (44px at the default 16px root font — WCAG touch-target floor (44px at the default 16px root font — WCAG
@ -15,13 +15,13 @@
The field wrapper repeats `.ui-form-control`'s own `width: 100%` The field wrapper repeats `.ui-form-control`'s own `width: 100%`
rather than leaving the wrapper unconstrained: inside a shrink-to-fit rather than leaving the wrapper unconstrained: inside a shrink-to-fit
flex column (`CreateAgentPage`'s form is one), an unconstrained flex column (`CreateAgentForm`'s form is one), an unconstrained
wrapper sizes to its own content — and a `width: 100%` *control* wrapper sizes to its own content — and a `width: 100%` *control*
inside an auto-width wrapper resolves against that shrunk width, not inside an auto-width wrapper resolves against that shrunk width, not
the container the page actually gave it, so two fields with the container the page actually gave it, so two fields with
differently-long labels ("agent name" vs "hive") ended up with differently-long labels ("agent name" vs "hive") ended up with
differently-wide inputs — the misalignment mara reported on the differently-wide inputs — the misalignment mara reported on the
create-agent page. Matching the two declarations here means every create-agent form. Matching the two declarations here means every
field's control width is driven by the same container width field's control width is driven by the same container width
regardless of its label's length or its siblings'. */ regardless of its label's length or its siblings'. */
.ui-form-field { .ui-form-field {

2
frontend/packages/swarm-ui/src/ui/panel/Panel.tsx
View file

@ -15,7 +15,7 @@
// `icon` is a small header glyph, left of the title — the swarm-ui // `icon` is a small header glyph, left of the title — the swarm-ui
// design guide's own whimsy reference (before this, the guide only // design guide's own whimsy reference (before this, the guide only
// pointed at the dashboard's matrix-rain background). Grew out of // pointed at the dashboard's matrix-rain background). Grew out of
// CreateAgentPage's one-off 🪪 dropped straight into a panel's body // CreateAgentForm's one-off 🪪 dropped straight into a panel's body
// copy: mara's call on review was that a single ad-hoc emoji isn't // copy: mara's call on review was that a single ad-hoc emoji isn't
// whimsy in the guide's sense (small, delightful, *consistent*), it // whimsy in the guide's sense (small, delightful, *consistent*), it
// should be a real theme every panel can opt into the same way. Plain // should be a real theme every panel can opt into the same way. Plain

2
frontend/packages/swarm-ui/src/ui/text-field/TextField.tsx
View file

@ -1,5 +1,5 @@
// <TextField> — a labelled single-line text input, the shared control // <TextField> — a labelled single-line text input, the shared control
// every page-level form (`CreateAgentPage` today) reaches for instead // every form (`CreateAgentForm` today) reaches for instead
// of hand-rolling its own label/input pair. No textarea/multi-line // of hand-rolling its own label/input pair. No textarea/multi-line
// mode — promote that the day a real caller needs one, same "don't // mode — promote that the day a real caller needs one, same "don't
// build ahead of a caller" rule the rest of `ui/` follows. // build ahead of a caller" rule the rest of `ui/` follows.