From 4fd6480c9cf80eedfd21d237f9014ffe52376638 Mon Sep 17 00:00:00 2001 From: iris Date: Mon, 24 Aug 2026 00:34:34 +0200 Subject: [PATCH] fixup: update stale CreateAgentPage cross-references (argus review) Three doc comments elsewhere in the tree still named the old CreateAgentPage identifier/page framing after the rename in this branch -- TextField.tsx, Panel.tsx, FormField.css (x3). None of these files are touched by the rest of the diff, which is exactly how the staleness happened. --- frontend/packages/swarm-ui/src/ui/form-field/FormField.css | 6 +++--- frontend/packages/swarm-ui/src/ui/panel/Panel.tsx | 2 +- frontend/packages/swarm-ui/src/ui/text-field/TextField.tsx | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/frontend/packages/swarm-ui/src/ui/form-field/FormField.css b/frontend/packages/swarm-ui/src/ui/form-field/FormField.css index ed4f1393..94906f12 100644 --- a/frontend/packages/swarm-ui/src/ui/form-field/FormField.css +++ b/frontend/packages/swarm-ui/src/ui/form-field/FormField.css @@ -3,7 +3,7 @@ from (one class, so the two never drift). `width: 100%` fills whichever container the caller gives it — the kit itself has no opinion on a maximum width; a page that wants one narrower than its - own layout caps it at the layout level (`CreateAgentPage.css`'s + own layout caps it at the layout level (`CreateAgentForm.css`'s `.create-agent-form-col` is the existing example), same reasoning `Panel` has no width opinion of its own either. `min-height` is a touch-target floor (44px at the default 16px root font — WCAG @@ -15,13 +15,13 @@ The field wrapper repeats `.ui-form-control`'s own `width: 100%` rather than leaving the wrapper unconstrained: inside a shrink-to-fit - flex column (`CreateAgentPage`'s form is one), an unconstrained + flex column (`CreateAgentForm`'s form is one), an unconstrained wrapper sizes to its own content — and a `width: 100%` *control* inside an auto-width wrapper resolves against that shrunk width, not the container the page actually gave it, so two fields with differently-long labels ("agent name" vs "hive") ended up with differently-wide inputs — the misalignment mara reported on the - create-agent page. Matching the two declarations here means every + create-agent form. Matching the two declarations here means every field's control width is driven by the same container width regardless of its label's length or its siblings'. */ .ui-form-field { diff --git a/frontend/packages/swarm-ui/src/ui/panel/Panel.tsx b/frontend/packages/swarm-ui/src/ui/panel/Panel.tsx index 01265adf..d74bcdb3 100644 --- a/frontend/packages/swarm-ui/src/ui/panel/Panel.tsx +++ b/frontend/packages/swarm-ui/src/ui/panel/Panel.tsx @@ -15,7 +15,7 @@ // `icon` is a small header glyph, left of the title — the swarm-ui // design guide's own whimsy reference (before this, the guide only // pointed at the dashboard's matrix-rain background). Grew out of -// CreateAgentPage's one-off 🪪 dropped straight into a panel's body +// CreateAgentForm's one-off 🪪 dropped straight into a panel's body // copy: mara's call on review was that a single ad-hoc emoji isn't // whimsy in the guide's sense (small, delightful, *consistent*), it // should be a real theme every panel can opt into the same way. Plain diff --git a/frontend/packages/swarm-ui/src/ui/text-field/TextField.tsx b/frontend/packages/swarm-ui/src/ui/text-field/TextField.tsx index c759e6f6..e0cba5ef 100644 --- a/frontend/packages/swarm-ui/src/ui/text-field/TextField.tsx +++ b/frontend/packages/swarm-ui/src/ui/text-field/TextField.tsx @@ -1,5 +1,5 @@ // — a labelled single-line text input, the shared control -// every page-level form (`CreateAgentPage` today) reaches for instead +// every form (`CreateAgentForm` today) reaches for instead // of hand-rolling its own label/input pair. No textarea/multi-line // mode — promote that the day a real caller needs one, same "don't // build ahead of a caller" rule the rest of `ui/` follows.