vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

matrix: fix stale admin-room comment pointing at closed issue

Browse source 
The comment pointed readers at an 'open question tracked on the forge'
for whether the admin-room polling in promote_user_to_admin could
become a direct HTTP call — but the tracking issue is closed. Upstream
tuwunel does not plan to add Synapse's user-creation admin endpoint
(it implements some _synapse/admin/* routes, just not that one), so
the admin-room mechanism is the intended long-term approach, not a
stopgap. Rewrite the comment to state that instead of inviting
re-investigation.

Refs #3561
This commit is contained in:
atlas 2026-09-15 00:52:29 +02:00 • committed by mara
commit 0890b1eaa0
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
hive-c0re/src/matrix.rs
View file

@ -888,10 +888,10 @@ pub async fn ensure_admin_user(client: &reqwest::Client, register_token: &str) -
/// (`#admins:<server>`). Sends `!admin users make-user-admin @<localpart>:<server>` as /// (`#admins:<server>`). Sends `!admin users make-user-admin @<localpart>:<server>` as
/// @hive, polls for the bot's "Done:" success response. /// @hive, polls for the bot's "Done:" success response.
/// ///
/// Workaround for a once-missing `/_synapse/admin/v2/users` in tuwunel — /// Goes through the admin room rather than a direct HTTP call because
/// not re-verified against the version currently deployed. Whether the /// tuwunel implements parts of the Synapse admin API but not user
/// admin-room polling here can become a direct HTTP call is an open /// creation, and upstream does not intend to add it. This is the
/// question tracked on the forge. /// intended long-term mechanism, not a stopgap awaiting an upstream fix.
pub async fn promote_user_to_admin( pub async fn promote_user_to_admin(
client: &reqwest::Client, client: &reqwest::Client,
admin_token: &str, admin_token: &str,