From 0890b1eaa0f5010cad98d7d1936d9de5aef8fb82 Mon Sep 17 00:00:00 2001 From: atlas Date: Tue, 15 Sep 2026 00:52:29 +0200 Subject: [PATCH] matrix: fix stale admin-room comment pointing at closed issue MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The comment pointed readers at an 'open question tracked on the forge' for whether the admin-room polling in promote_user_to_admin could become a direct HTTP call — but the tracking issue is closed. Upstream tuwunel does not plan to add Synapse's user-creation admin endpoint (it implements some _synapse/admin/* routes, just not that one), so the admin-room mechanism is the intended long-term approach, not a stopgap. Rewrite the comment to state that instead of inviting re-investigation. Refs #3561 --- hive-c0re/src/matrix.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hive-c0re/src/matrix.rs b/hive-c0re/src/matrix.rs index a750ef26..720c851d 100644 --- a/hive-c0re/src/matrix.rs +++ b/hive-c0re/src/matrix.rs @@ -888,10 +888,10 @@ pub async fn ensure_admin_user(client: &reqwest::Client, register_token: &str) - /// (`#admins:`). Sends `!admin users make-user-admin @:` as /// @hive, polls for the bot's "Done:" success response. /// -/// Workaround for a once-missing `/_synapse/admin/v2/users` in tuwunel — -/// not re-verified against the version currently deployed. Whether the -/// admin-room polling here can become a direct HTTP call is an open -/// question tracked on the forge. +/// Goes through the admin room rather than a direct HTTP call because +/// tuwunel implements parts of the Synapse admin API but not user +/// creation, and upstream does not intend to add it. This is the +/// intended long-term mechanism, not a stopgap awaiting an upstream fix. pub async fn promote_user_to_admin( client: &reqwest::Client, admin_token: &str,