Watch
0
0
Fork
You've already forked hyperhive
0
Commit graph hyperhive/hive-forge/src/verbs
Author SHA1 Message Date
atlas
1edeb5c55d agents get a per-agent repo limit in their permissions record, orgs are locked
max_repos (default 0, 0..=100) lives in the agent's agent-permissions record and is edited on its permissions panel. The controller applies each agent's own value as max_repo_creation at CreateForgeUser and to existing accounts on change, restart and every five minutes; agent accounts may not create organizations.
2026-11-16 01:21:25 +01:00
atlas
4a109fa038 hive-forge: state the read-state contract in the guard docs 2026-11-15 21:06:23 +01:00
atlas
cbfd7b2174 hive-forge repo-add-collaborator: module doc no longer implies agents create repos 2026-11-12 21:19:52 +01:00
atlas
6ec12e7d84 hive-forge repo-create: say the account can't create repos instead of a bare 500 2026-11-12 21:11:41 +01:00
damocles
de3c5cbb65 hive-forge: let pr reviews take --at and -m text that starts with a hyphen 2026-11-10 06:48:39 +01:00
damocles
eda7120f08 hive-forge: post inline review comments with pr reviews --at, number diff lines with pr diff --numbered 2026-11-09 21:39:44 +01:00
iris
6739bb903d docs: sort the top-level directories into five sections by what the reader wants
Every docs directory moves under 1-getting-started, 2-handbook,
4-implementation or 5-project; the options reference (section 3) comes from
the website and has no directory here. trust-boundary stays whole under the
handbook for now. web-ui, swarm and tools split between handbook and
implementation, and the command-line references move to
2-handbook/reference. Links, path references in code and nix, and the docs
index follow the moves; no page content changes.
2026-11-06 18:46:57 +01:00
damocles
c8c5a19761 hive-forge: pr reviews names the poster of an inline comment that is not the reviewer's 2026-11-05 09:56:08 +01:00
damocles
3ff4dc7be0 hive-forge: review-reply adds the comment to the answered comment's review, as the web UI does 2026-11-05 08:31:43 +01:00
damocles
66837e7c10 hive-forge: pr review-reply answers an inline review comment in its conversation 2026-11-05 08:31:43 +01:00
damocles
1dc18d41d4 forge cli: unresolved filter drops only resolved comments, position-less ones stay labelled 2026-11-01 02:26:29 +01:00
damocles
219d85a15d forge cli: show comment ids and resolved state on inline review comments, --only unresolved, and list them in pr timeline 2026-11-01 02:26:29 +01:00
atlas
a70b25847e refuse a dependency add of an issue on itself 2026-10-27 14:52:41 +01:00
atlas
8895bfc63f document the cycle refusal in dependency add help 2026-10-27 14:52:41 +01:00
atlas
347b8119b2 refuse a dependency add that would close a cycle 2026-10-27 14:52:41 +01:00
atlas
7dd5d30da8 remove the /shared bind from agent containers 2026-10-26 21:33:05 +01:00
damocles
1ff4a0057e hive-forge: pr status lists only pending review requests 2026-10-26 18:44:29 +01:00
damocles
ff4fd93f81 hive-forge: pr assign-reviewer --remove fails when the reviewer is still listed afterwards 2026-10-26 17:57:03 +01:00
atlas
463c5cbfcc share the standing-review rule between hive-forge and the controller
pr assign-reviewer behaves as before; the latest-review fold and the
superseded check move to hive-types::review.
2026-10-24 17:23:28 +02:00
atlas
62a8a40e90 hive-forge list trusts the forge's own next-page signal for its trailer 2026-10-21 00:50:01 +02:00
atlas
6859eb7f37 hive-forge list's paging trailer counts the rows actually shown
The trailer computed shown as page * rows-on-this-page, so a short last
page (page 27 of 1331 rows at 50/page, 31 rows) was counted as 837 of
1331 and printed a hint to fetch page 28. A page whose unclamped row
offset lands exactly on the total is now recognised as the last one, so
the trailer stays silent there. Shown is also clamped to the total.
2026-10-21 00:34:39 +02:00
damocles
c335bc0962 repo-search: don't tell the caller to raise --limit once the forge has already clamped 2026-10-14 19:37:43 +02:00
damocles
acb5b676d7 repo-search: read X-Total-Count so the warning fires at the server's own clamp 2026-10-14 19:37:43 +02:00
damocles
54b8122f66 repo-search: warn when a result count hits --limit, may be truncated 2026-10-14 19:37:43 +02:00
atlas
9e3a00825b hive-forge: pr edit --base retargets a PR
Forgejo's issue edit endpoint (/issues/<n>) has no base field, so `pr edit`
could not retarget a stacked PR once its base merged. `--base <BRANCH>`
(non-empty) switches the edit onto PATCH /pulls/<n>, which carries `base`
alongside title/body/state/milestone. Without `--base`, `pr edit` is
unchanged and still goes through the issue endpoint.
2026-10-13 08:37:13 +02:00
atlas
3d81266483 hive-forge: comments --since --limit returns N, not at most 49
The issue-comments endpoint takes no page or limit, so `comments
--since` cut its window client-side from a whole-list response. The
leftover over-fetch-by-one request (`.page_size(limit + 1)`) was a
no-op and the `--limit` clamp to MAX_LIMIT (49) guarded a truncation
check that no longer needs one.

Drop both: `--since T --limit N` now returns N comments. `comments
--json` still emits `since_limit_clamped`, always `false`. `timeline`
is untouched; its endpoint pages and its clamp stays.
2026-10-09 21:46:14 +02:00
atlas
1d56a74aad hive-forge: fetch issue comments in one request; the endpoint has no paging
The forge's issue-comments endpoint takes no page or limit and always
returns the whole thread. #5055 wrapped view's fetch in all_pages, which
never saw a short page on a thread of 50+ comments and fetched the same
list 50 times: `issue view 3782` printed 3000 comments instead of 60.
`comments --limit K` sent K as a page size the forge ignored, so it
returned the whole thread.

view and pr status's last_comment now send one request. comments fetches
the thread once and cuts the --limit / --tail window client-side; the
X-Total-Count probe and the computed-page tail walk are gone, and the
count of comments outside the window is the length of the list.
--since is unchanged.

tests/comments_no_paging.rs runs the binary against a loopback mock
forge whose comments route ignores page and limit, as Forgejo's does.
2026-10-09 21:19:47 +02:00
damocles
d11c9537b6 hive-forge: drop subscription --ignore entirely — Forgejo only has watch/unwatch 2026-10-09 13:26:43 +02:00
damocles
7b4ef40688 hive-forge: inline test Args literals, drop the 4-bool helper (clippy::fn_params_excessive_bools) 2026-10-09 13:26:43 +02:00
damocles
f85db2b773 hive-forge: fix displaced run() doc comment, make the --ignore test pin behaviour not a string 2026-10-09 13:26:43 +02:00
damocles
31c7623a69 hive-forge: regenerate forge-cli.md, pin --ignore refusal with a test 2026-10-09 13:26:43 +02:00
damocles
902c1ae574 hive-forge: subscription --ignore refuses instead of silently watching (#5052) 2026-10-09 13:26:43 +02:00
atlas
4e6c3b4a2f hive-forge: pr create --draft: extract draft_warning so the warning decision is tested 2026-10-09 12:51:22 +02:00
atlas
4d164819b3 hive-forge: drop the subscription --ignore change (covered by #5053) 2026-10-09 12:51:22 +02:00
atlas
6e32b432ec hive-forge: subscription --ignore errors instead of subscribing; warn on --draft; always print agit PR URL 2026-10-09 12:51:22 +02:00
atlas
0e5c61d12c hive-forge: page past the forge's 50-row clamp; show list --json truncation
The forge clamps page_size to 50. branches, pr reviews, the review
bodies merged into `comments <pr>`, and view's comment list each sent
one request, so anything past the first page was dropped silently.
labels::repo_labels did loop, but asked for 100/page and stopped on
`len < 100`, so a clamped full page of 50 ended the walk.

Add verbs::all_pages: requests 50/page until a short page, capped at
50 pages with a stderr warning when the cap is hit. Use it in all of
the above; repo-labels now calls labels::repo_labels instead of its
own copy of the loop.

list --json now prints the same "N of M shown" stderr trailer as the
pretty output; its paging and stdout shape are unchanged.

Closes #5051
2026-10-09 12:35:51 +02:00
atlas
6bb13f964d hive-c0re: validate forge env at startup; char-safe short revs
HIVE_FORGE_URL (set + parseable) and HIVE_ASSETS_DIR are checked once in
main before workers start. Short revs in container_view and pr_status
take 12 chars instead of byte-slicing.
2026-10-09 10:51:39 +02:00
damocles
111c27e225 hive-forge: credential-helper fails closed when the configured forge URL won't parse 2026-10-04 14:31:05 +02:00
damocles
c531d39537 hive-forge: refuse_json for pr diff names the verb that actually exists 2026-10-04 08:15:28 +02:00
damocles
e18497bb70 hive-forge: dedup the --json refusal into refuse_json(), test it, cover attachment-get/artifact-get too 2026-10-04 08:10:52 +02:00
damocles
e0ad3a567b hive-forge: add body to pr show --json, error --json on six verbs that silently ignored it 2026-10-04 08:04:19 +02:00
atlas
9986da4c7f hive-forge: attach-issue/attach-comment fail on a missing download URL
print_url only printed when browser_download_url was Some, so a 2xx
upload response with no URL printed nothing and still exited 0 — a
caller doing url=$(hive-forge attach-issue …) got an empty string with
no signal anything went wrong.

require_url now errors, naming the attachment's id/name, when the
forge returns no download URL.
2026-09-24 13:50:24 +02:00
atlas
6ac402ed2d hive-forge: labels remove refuses unknown names and verifies removal landed
labels <n> remove used to silently skip an unknown label name (lookup_id
returning None just did nothing) and discard each remove call's Result,
so a typo or a forge-rejected removal (403, insufficient permission)
both exited 0 with the label untouched.

Resolve names through the same resolve_ids labels add already uses, so
an unknown name is refused before anything is removed. After removing,
re-fetch and diff against what was requested — following assign.rs's
same before/after check — and bail! naming any label still present.
2026-09-24 13:50:24 +02:00
atlas
392f16cbc0 hive-forge: ci-rerun --run refuses on a PR-triggered run too
--run <id> against a run that was itself PR-triggered has the identical
defect #4632 fixed for --pr: a workflow_dispatch run writes no commit
status, so it can't clear the red (pull_request) check on that PR's sha
no matter how the dispatched run turns out.

resolve_run already distinguishes this case -- it recognizes a run's
prettyref as a PR pseudo-ref (#<n>) via pr_number_from_run_ref, then
used to call branch_for_pr to keep going. It now bails with the same
pr_refusal_message --pr uses instead, before ever building a dispatch
request. branch_for_pr has no other caller (--pr refuses before
touching it too, since #4632), so it's removed rather than left dead.

Push (non-PR-triggered) and --branch are untouched.

Regenerated docs/tools/forge-cli.md from clap help; corrected
docs/tools/forge.md's claim that --run always works.
2026-09-21 21:37:22 +02:00
atlas
8de85729cc hive-forge: make ci-rerun --pr help text match the refusal it prints
The doc comment still described the old (never-shipped) behavior --
exactly the lie this whole PR exists to remove, just in --help instead
of the module doc or forge.md. Say what the flag actually does: refuse,
because a workflow_dispatch run writes no commit status and can't clear
a red (pull_request) check.

Regenerated docs/tools/forge-cli.md (derived from clap help via
'hive-forge markdown-docs').
2026-09-21 20:55:34 +02:00
atlas
92100ac1f8 hive-forge: ci-rerun --pr refuses instead of lying about a fix it can't achieve
A workflow_dispatch run writes no commit status, so ci-rerun --pr could
never clear the red (pull_request) check it claimed to be re-running for
- it dispatched a fresh run and printed a success message regardless,
even though the check stays red no matter how that run turns out.

--pr now refuses up front, before dispatching, naming the mechanism and
the working alternative (re-run from the web UI). --run and --branch are
unchanged: --run's own PR-pseudo-ref resolution and --branch's direct
dispatch are both untouched.

Fixes the exit-code/honesty defect from #4613; the workflow_dispatch vs.
pull_request event-type question (whether to close+reopen the PR to fire
a real pull_request event) is a separate, parked decision.
2026-09-21 20:55:34 +02:00
atlas
8e6c813325 hive-forge: print the ref ci-runs --branch resolved to
qualify_ref (ci_runs.rs:84-93) reads '#N' and an all-digit value as a PR,
anything else as a branch — so '--branch #4540' and '--branch
ops-4502-swarm-agent-icon' for the same PR/head commit answer two disjoint
questions with no indication which one was asked. Print the resolved ref
to stderr whenever --branch is given, so the output states which question
it answered.

Stdout is untouched in both plain and --json mode, so no existing
invocation's parsed output changes. An all-digit branch name stays
reachable via --branch refs/heads/<name> (already documented, unchanged).
2026-09-20 17:49:42 +02:00
atlas
f0e3ed04d3 hive-forge, hivectl, swarmctl: fix clap help passive voice, regen docs
Rewrites every write-good.Passive hit in the hive-forge clap help text
into terse, imperative, active voice (meaning unchanged) and drops
clap-markdown's own fixed footer ('This document was generated
automatically by...') via MarkdownOptions::show_footer(false), since
that string isn't ours to reword and vale flagged it too.

docs/tools/{hivectl,swarmctl,forge}-cli.md are generated from each
crate's clap tree (see hive-forge/src/main.rs's MarkdownDocs verb) —
regenerated here from the fixed source, not hand-edited.

Refs #4549
2026-09-20 13:49:39 +02:00
atlas
15424d3e49 hive-forge: move pr create --remote's origin default onto the clap arg
Puts the default on #[arg(long, default_value = "origin")] instead of
duplicating unwrap_or("origin") at both call sites (REST/--push path
and agit_create). clap now renders the default in --help itself, so
the hand-written doc-comment default is dropped in favor of it.
Regenerated docs/tools/forge-cli.md to match.
2026-09-19 20:33:48 +02:00
atlas
18f0199566 hive-forge: default pr create --push remote to origin
Fresh clones only have origin, not forge. The --remote override
already covers anyone using a different name.

Closes #4538
2026-09-19 18:16:55 +02:00