review-classifier: a pure deletion of code and its tests needs no new test
This commit is contained in:
parent
4b08dde82e
commit
533a39a00b
1 changed files with 3 additions and 1 deletions
|
|
@ -54,7 +54,9 @@ classifications:
|
||||||
`nix/checks.nix`, a crate's `tests/` directory, or Rust inside
|
`nix/checks.nix`, a crate's `tests/` directory, or Rust inside
|
||||||
`#[cfg(test)]` or a `#[test]` function) changes no behaviour: the
|
`#[cfg(test)]` or a `#[test]` function) changes no behaviour: the
|
||||||
question is not applicable. So is a diff that changes only
|
question is not applicable. So is a diff that changes only
|
||||||
documentation. A NixOS module assertion, a Grafana/alerting rule, or
|
documentation. So is a diff that only deletes code together with the
|
||||||
|
tests of that code and adds no logic: nothing new needs a test. A NixOS
|
||||||
|
module assertion, a Grafana/alerting rule, or
|
||||||
the literal text of a log or tracing message is not held to this
|
the literal text of a log or tracing message is not held to this
|
||||||
either. A PR that changes logic and tests together matches.
|
either. A PR that changes logic and tests together matches.
|
||||||
polarity: positive
|
polarity: positive
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue