From 533a39a00bdd39955e46511fb3f13cd9188215c6 Mon Sep 17 00:00:00 2001 From: argus Date: Sat, 7 Nov 2026 09:20:41 +0100 Subject: [PATCH] review-classifier: a pure deletion of code and its tests needs no new test --- .hyperhive/review-classifier.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.hyperhive/review-classifier.yml b/.hyperhive/review-classifier.yml index 3874f7e2..6512fc98 100644 --- a/.hyperhive/review-classifier.yml +++ b/.hyperhive/review-classifier.yml @@ -54,7 +54,9 @@ classifications: `nix/checks.nix`, a crate's `tests/` directory, or Rust inside `#[cfg(test)]` or a `#[test]` function) changes no behaviour: the question is not applicable. So is a diff that changes only - documentation. A NixOS module assertion, a Grafana/alerting rule, or + documentation. So is a diff that only deletes code together with the + tests of that code and adds no logic: nothing new needs a test. A NixOS + module assertion, a Grafana/alerting rule, or the literal text of a log or tracing message is not held to this either. A PR that changes logic and tests together matches. polarity: positive