From 59459019fc98454ea23accf1b7c77bb1771e3863 Mon Sep 17 00:00:00 2001
From: Vinzenz Schroeter <vinzenz.f.s@gmail.com>
Date: Tue, 7 May 2024 13:41:10 +0200
Subject: [PATCH] sticky dialog title

---
 tank-frontend/src/components/Dialog.tsx | 12 +++++++-----
 tank-frontend/src/components/Input.tsx  |  4 ++--
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/tank-frontend/src/components/Dialog.tsx b/tank-frontend/src/components/Dialog.tsx
index 8db7d7e..86130ad 100644
--- a/tank-frontend/src/components/Dialog.tsx
+++ b/tank-frontend/src/components/Dialog.tsx
@@ -10,11 +10,13 @@ export default function Dialog({children, className, title, onClose}: {
     className?: string;
     onClose?: () => void;
 }) {
-    return <Column className={'Dialog overflow-scroll ' + (className ?? '')}>
+    return <Column className={'Dialog ' + (className ?? '')}>
         <Row>
-            <h3 className='flex-grow'>{title}</h3>
-            {onClose && <Button text='x' onClick={onClose} />}
+            <h3 className="flex-grow">{title}</h3>
+            {onClose && <Button text="x" onClick={onClose}/>}
         </Row>
-        {children}
-    </Column>
+        <Column className='overflow-scroll'>
+            {children}
+        </Column>
+    </Column>;
 }
diff --git a/tank-frontend/src/components/Input.tsx b/tank-frontend/src/components/Input.tsx
index f2d7df6..002da6b 100644
--- a/tank-frontend/src/components/Input.tsx
+++ b/tank-frontend/src/components/Input.tsx
@@ -5,7 +5,7 @@ export function TextInput( {onChange, className, value, placeholder, onEnter }:
     onChange?: ChangeEventHandler<HTMLInputElement> | undefined;
     className?: string;
     value: string;
-    placeholder: string;
+    placeholder?: string;
     onEnter?: () => void;
 }) {
     return <input
@@ -25,7 +25,7 @@ export function NumberInput( {onChange, className, value, placeholder, onEnter }
     onChange?: ChangeEventHandler<HTMLInputElement> | undefined;
     className?: string;
     value: number;
-    placeholder: string;
+    placeholder?: string;
     onEnter?: () => void;
 }) {
     return <input