From 8c2ff6203f526484c06c30f2135a37db36a240c1 Mon Sep 17 00:00:00 2001 From: Damocles Date: Fri, 17 Apr 2026 09:09:42 +0200 Subject: [PATCH] fix window title: move visibility to bargroup to avoid binding deadlock --- modules/Bar.qml | 1 + modules/Modules.qml | 3 --- modules/NiriIpc.qml | 6 +----- modules/WindowTitle.qml | 6 ------ 4 files changed, 2 insertions(+), 14 deletions(-) diff --git a/modules/Bar.qml b/modules/Bar.qml index 9f28199..b6c5a23 100644 --- a/modules/Bar.qml +++ b/modules/Bar.qml @@ -144,6 +144,7 @@ PanelWindow { id: _windowTitleGroup Layout.minimumWidth: 0 clip: true + visible: M.Modules.windowTitle.enable && M.NiriIpc.focusedTitle !== "" M.WindowTitle { width: Math.max(0, centerSection.x - _windowTitleGroup.x - 2 * M.Theme.groupPadding - M.Theme.groupSpacing) } diff --git a/modules/Modules.qml b/modules/Modules.qml index e8cc31d..70a2d5d 100644 --- a/modules/Modules.qml +++ b/modules/Modules.qml @@ -111,8 +111,6 @@ QtObject { try { data = JSON.parse(raw); } catch (e) {} - console.log("Modules._apply keys=" + Object.keys(data).length + " windowTitle=" + JSON.stringify(data.windowTitle)); - // Enable all modules that aren't explicitly mentioned in the JSON for (const k of _moduleKeys) { if (!(k in data)) @@ -121,7 +119,6 @@ QtObject { }); } - console.log("Modules._apply after defaults: windowTitle.enable=" + root.windowTitle.enable); // Apply JSON overrides for (const k of Object.keys(data)) { if (!(k in root)) diff --git a/modules/NiriIpc.qml b/modules/NiriIpc.qml index 84edea1..ec37937 100644 --- a/modules/NiriIpc.qml +++ b/modules/NiriIpc.qml @@ -22,7 +22,6 @@ QtObject { command: ["niri", "msg", "--json", "focused-window"] stdout: StdioCollector { onStreamFinished: { - console.log("NiriIpc._focusedProc raw='" + text.slice(0, 80) + "'"); try { const w = JSON.parse(text); if (w) { @@ -32,10 +31,7 @@ QtObject { root.focusedTitle = ""; root.focusedAppId = ""; } - } catch (e) { - console.log("NiriIpc._focusedProc parse error: " + e); - } - console.log("NiriIpc focusedTitle='" + root.focusedTitle + "'"); + } catch (e) {} } } } diff --git a/modules/WindowTitle.qml b/modules/WindowTitle.qml index 839a13b..ebb7bdf 100644 --- a/modules/WindowTitle.qml +++ b/modules/WindowTitle.qml @@ -7,12 +7,6 @@ import "." as M M.BarSection { id: root spacing: M.Theme.moduleSpacing - visible: M.Modules.windowTitle.enable && M.NiriIpc.focusedTitle !== "" - - onVisibleChanged: console.log("WindowTitle visible=" + visible + " enable=" + M.Modules.windowTitle.enable + " title='" + M.NiriIpc.focusedTitle + "' width=" + width) - onWidthChanged: if (visible) - console.log("WindowTitle width=" + width + " centerSection.x would need bar ref") - tooltip: M.NiriIpc.focusedAppId ? M.NiriIpc.focusedAppId + "\n" + M.NiriIpc.focusedTitle : M.NiriIpc.focusedTitle readonly property string _iconSource: {