vinzenz/nova-shell
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

bar modules own active state, fix circular effectiveVisible deadlock in BarGroup

Browse source
This commit is contained in:
Damocles 2026-04-26 18:45:11 +02:00
parent 7eaa50327f
commit 7e594b7f8d
24 changed files with 52 additions and 73 deletions
Download patch file Download diff file Expand all files Collapse all files

13
shell/modules/BarGroup.qml
View file

@ -27,7 +27,18 @@ Item {
readonly property real _blr: S.Theme.radius
readonly property real _brr: S.Theme.radius
visible: row.visibleChildren.length > 0
// Check children's `active` instead of visibleChildren to avoid circular
// effectiveVisible dependency: if the BarGroup is invisible, children's
// effectiveVisible is always false, so visibleChildren stays empty and
// the group can never become visible again. `active` is a plain property
// on BarModule that is not affected by the parent visibility chain.
visible: {
for (let i = 0; i < row.children.length; i++) {
if (row.children[i].active)
return true;
}
return false;
}
implicitWidth: row.implicitWidth + _pad * 2
implicitHeight: S.Theme.barHeight - 3 - _pad