From 1886f27268808ae7226d54cf5f6ffe6d8f5aef9b Mon Sep 17 00:00:00 2001 From: Damocles Date: Sun, 12 Apr 2026 12:35:23 +0200 Subject: [PATCH] remove TODO --- PLAN-traymenu-fix.md | 60 -------------------------------------------- 1 file changed, 60 deletions(-) delete mode 100644 PLAN-traymenu-fix.md diff --git a/PLAN-traymenu-fix.md b/PLAN-traymenu-fix.md deleted file mode 100644 index 3b544d0..0000000 --- a/PLAN-traymenu-fix.md +++ /dev/null @@ -1,60 +0,0 @@ -# Plan: fix tray menu grey bar - -## Root cause - -`Column` (a QML positioner) lays out children using their `height` property. -`implicitHeight` is advisory — layouts like `ColumnLayout` use it, but plain -`Column` does not. The delegate `Item`s in `TrayMenu.qml` set `implicitHeight` -but leave `height` at its default of 0, so every row collapses. The only -visible pixels are the Column's `topPadding + bottomPadding = 8 px` — the grey -bar. - -The same mistake applies to `implicitWidth` on the delegate items and the back -button; the width happens to work because the children use `anchors` relative to -`parent` which already has `width: 220` from the Column, but it is still wrong -and should be fixed for clarity. - -## Fix — TrayMenu.qml only, two places - -### 1. Back button Item (line ~108) - -```qml -// before -implicitWidth: page.implicitWidth -implicitHeight: 28 - -// after -width: page.width -height: 28 -``` - -### 2. Repeater delegate Item (line ~142) - -```qml -// before -implicitWidth: page.implicitWidth -implicitHeight: modelData.isSeparator ? 9 : 28 - -// after -width: page.width -height: modelData.isSeparator ? 9 : 28 -``` - -## Also check: StackView height binding - -The StackView currently binds: - -```qml -height: currentItem ? currentItem.implicitHeight : 0 -``` - -`Column.implicitHeight` is computed from children's `implicitHeight` (not -`height`), so it should be correct in principle — but once the delegate items -have a real `height`, `Column.implicitHeight` will equal `Column.height` -anyway. Worth verifying that `currentItem.implicitHeight` and -`currentItem.height` agree after the fix; if not, switch to `currentItem.height`. - -## Expected result - -Each menu row is 28 px tall (9 px for separators). The panel Rectangle sizes -correctly. The dismiss MouseArea still works. No other files need changing.