hyperhive/hive-forge/src
Repository files (latest commit first)
Filename Latest commit message Latest commit date
damocles 8b83eca0c1 fix(#3435): hive-forge issue/pr show fail on forgejo's null-for-empty reactions
Forgejo returns a bare `null` body (not `[]`) for a reactions list when
nothing has reacted yet. issue_reactions/comment_reactions deserialized
straight into forgejo-api's typed Vec<Reaction>, which has no null
tolerance, so issue show / pr show / view failed on every item with zero
reactions - i.e. nearly everything.

Generalize pr_status's existing null_as_empty (same quirk, hit earlier
on combined-status statuses) into a shared helper in verbs/mod.rs, and
fetch reactions via the raw JSON path (Client::get_api_json) with a
NullableVec<T> wrapper instead of the typed client's bare Vec<Reaction>.

Also names the failing request in errors going forward, since
get_api_json's error context includes the URL - closes the gap the
issue itself flagged (the old error said what didn't parse but not
what was fetched).
2026-08-18 15:26:07 +02:00
..
verbs fix(#3435): hive-forge issue/pr show fail on forgejo's null-for-empty reactions 2026-08-18 15:26:07 +02:00
body.rs ci(#1555): prose-ify legacy tracker tags; add lint:allow escape hatch 2026-06-10 13:14:42 +02:00
client.rs hive-forge: shell out to git for origin-remote inference instead of hand-parsing config 2026-07-29 18:44:28 +02:00
main.rs docs: cover the reaction verb and comments --show-reactions 2026-08-18 13:53:27 +02:00
notify.rs fix(#2565): lenient notifications deserialize in hive-forge read-guard 2026-07-17 16:45:56 +02:00