2ff4cddf9d
mara, PR review: "i dont like that they still have different styling.
if anything, there should be distinction between info,warning,error
(semantics). all warnings should be styled identically."
Replaces the severity ('amber'|'red') + standalone pulse boolean with
a single level ('info'|'warning'|'error') attribute -- a fixed
three-tier ladder instead of an open combination. Colours reuse
theme.css's own already-documented semantics rather than inventing new
ones: --cyan is already "info accents", --amber already "warnings",
--red already "errors, fail state". Pulse is now baked into `error`
specifically rather than a separate opt-in knob, since the one call
site that wanted attention-grabbing (an active incident) is also the
one that's semantically error -- tying the two together removes a
combination that shouldn't exist independently of the tier.
Reclassified the three call sites explicitly (no implicit default
relied on): credentials.html's GitHub PAT advisory and core.js's K3PT
ST4T3 caveat are both `level="warning"` (same as before, and now
identical to each other by construction, not by coincidence);
swarm.js's port-collision banner is `level="error"` (an active
incident needing operator action now, not a standing caveat).
npm run build clean both packages, grepped for leftover
severity/pulse references (only prose mentions describing what this
replaces).
41 lines
2 KiB
JavaScript
41 lines
2 KiB
JavaScript
// hive-warn.js — <hive-warn>, the shared inline warning-banner
|
|
// component. Consolidates three independently-written instances of the
|
|
// same thing: `.cred-warning` (credentials.html, static
|
|
// markup), `.tombstone-warn` (core.js, JS-built), `.port-conflict`
|
|
// (swarm.js, JS-built) — the first two differed only by an
|
|
// undeliberate 10% vs 8% tint, the strongest evidence this was drift,
|
|
// not three genuinely different needs.
|
|
//
|
|
// Purely presentational — no internal state, no lifecycle beyond
|
|
// attaching its shadow root once. `level` ('info' | 'warning' | 'error',
|
|
// default 'warning') is read directly by hive-warn.css's
|
|
// `:host([level="…"])` selectors — a fixed three-tier semantic ladder,
|
|
// not an open severity+modifier combination (mara, on review: "there
|
|
// should be distinction between info, warning, error — all warnings
|
|
// should be styled identically"). Unlike `<hive-btn>`'s
|
|
// `variant`/`disabled` there's no inner native element that needs the
|
|
// attribute mirrored onto it, so no `attributeChangedCallback` is
|
|
// needed at all — the CSS reads the host attribute directly.
|
|
//
|
|
// Content is arbitrary light-DOM children through the shadow tree's
|
|
// single default `<slot>` — same reuse of the existing `<strong>`/
|
|
// `<code>` markup every call site already writes, no caller-side
|
|
// rewrite of their message content needed.
|
|
//
|
|
// Usage:
|
|
// `<hive-warn level="warning">...</hive-warn>` (static HTML)
|
|
// `el('hive-warn', { level: 'warning' }, ...)` (JS-built)
|
|
// `el('hive-warn', { level: 'error' }, ...)` (active incident, pulses)
|
|
|
|
import { attachShadowCss } from '../shadow-css.js';
|
|
import hiveWarnCss from './hive-warn.css';
|
|
|
|
class HiveWarn extends HTMLElement {
|
|
connectedCallback() {
|
|
if (this._built) return; // re-parenting re-fires connectedCallback
|
|
const root = attachShadowCss(this, hiveWarnCss);
|
|
root.append(document.createElement('slot'));
|
|
this._built = true;
|
|
}
|
|
}
|
|
customElements.define('hive-warn', HiveWarn);
|