nix/host-modules/hive-forge/default.nix

@@ -807,27 +807,18 @@ in
               # forge.darkest.space, etc.) were failing every sync
               # attempt without this.
               migrations.ALLOWED_DOMAINS = "*";
-              # Forgejo's webhook SSRF allow-list, a strict whitelist.
+              # `ALLOWED_HOST_LIST` is forgejo's webhook SSRF allow-list, and
-              # `external` (public unicast only) stays, or user-repo webhooks to
+              # it's a STRICT whitelist (only listed hosts deliver). Its
-              # github/slack break; both hyperhive hosts are added because their
+              # default is the `external` builtin: all public unicast IPs are
-              # webhooks target a private gateway IP `external` denies. The
+              # allowed, private/loopback denied. We must KEEP `external` so
-              # swarm's host was the missing one, and every swarm-controller
+              # user-repo webhooks to public hosts (github, slack, …) keep
-              # delivery was refused for it.
+              # working, and ADD the hive gateway host on top: the config-PR +
-              #
+              # knowledge webhooks target `https://<hyperhive domain>/webhook/*`,
-              # Not gated on `deploy.swarm-ui.enable`: in a spread deployment the
+              # which resolves to a private (RFC-1918) gateway IP that
-              # forge and the swarm host are different machines, so that
+              # `external` alone would deny (so they'd only ever be caught by
-              # per-host flag is false exactly where this entry is needed.
+              # the 5-min poll fallback). Naming the single gateway host is
-              # `swarm.ui.domain` is the option the controller builds its public
+              # tighter than the broad `private` builtin.
-              # URL from; it is slated to collapse into `swarm.domain`.
+              webhook.ALLOWED_HOST_LIST = "external,${hyperhiveDomain}";
-              webhook.ALLOWED_HOST_LIST = lib.concatStringsSep "," (
-                lib.unique (
-                  [
-                    "external"
-                    hyperhiveDomain
-                  ]
-                  ++ lib.optional (swarmDomain != null) config.services.hyperhive.swarm.ui.domain
-                )
-              );
               log.LEVEL = "Warn";
               # Pinned explicitly rather than left to upstream's default
               # (currently `bleve`, a separate full-text index Forgejo