From f6d8dc9d66a9a5bbb0a711e20ab3f28f44dd1d97 Mon Sep 17 00:00:00 2001 From: damocles Date: Tue, 13 Oct 2026 14:22:00 +0200 Subject: [PATCH 1/2] review-classifier: narrow tests-with-behaviour to code behaviour, not nix/grafana/log-text --- .hyperhive/review-classifier.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.hyperhive/review-classifier.yml b/.hyperhive/review-classifier.yml index bb5f5fa2..347179d5 100644 --- a/.hyperhive/review-classifier.yml +++ b/.hyperhive/review-classifier.yml @@ -33,11 +33,14 @@ classifications: threshold: 75 - name: tests-with-behaviour description: >- - Every change to how the code behaves comes with a new or updated test - that exercises it. A diff whose changed files are all test code - (a fixture under `nix/module-eval/`, `nix/checks.nix`, a crate's + Every change to Rust or application code behaviour comes with a new or + updated test that exercises it. A diff whose changed files are all test + code (a fixture under `nix/module-eval/`, `nix/checks.nix`, a crate's `tests/` directory, or Rust inside `#[cfg(test)]` or a `#[test]` - function) changes no behaviour: the question is not applicable. A PR + function) changes no behaviour: the question is not applicable. A NixOS + module assertion, a Grafana/alerting rule, or the literal text of a log + or tracing message is not held to this either: none of those are tested + anywhere in this repo today, so the rule doesn't apply to them. A PR that changes behaviour and tests together matches. polarity: positive threshold: 65 From 503c8c8b3cc49d4d4d1d99f623629abf890dc237 Mon Sep 17 00:00:00 2001 From: damocles Date: Tue, 13 Oct 2026 14:31:28 +0200 Subject: [PATCH 2/2] review-classifier: drop point-in-time justification tail per argus --- .hyperhive/review-classifier.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.hyperhive/review-classifier.yml b/.hyperhive/review-classifier.yml index 347179d5..709c0adf 100644 --- a/.hyperhive/review-classifier.yml +++ b/.hyperhive/review-classifier.yml @@ -39,9 +39,8 @@ classifications: `tests/` directory, or Rust inside `#[cfg(test)]` or a `#[test]` function) changes no behaviour: the question is not applicable. A NixOS module assertion, a Grafana/alerting rule, or the literal text of a log - or tracing message is not held to this either: none of those are tested - anywhere in this repo today, so the rule doesn't apply to them. A PR - that changes behaviour and tests together matches. + or tracing message is not held to this either. A PR that changes + behaviour and tests together matches. polarity: positive threshold: 65 - name: docs-updated