Compare commits

..
5 changed files with 23 additions and 70 deletions

View file

@ -1,10 +1,6 @@
/* <LinksMenu> a single header icon-button + popover. Kept visually /* <LinksMenu> a single header icon-button + popover. Kept visually
quiet (no border/fill until interacted with) so it reads as chrome, quiet (no border/fill until interacted with) so it reads as chrome,
not another nav item. Button is sized to the same touch-target floor not another nav item. */
as the shared `ui/` kit (2.75em 44px, WCAG 2.5.5) even though it
isn't built from that kit a bespoke icon trigger, not a form
control, but the floor applies regardless of which component drew
it. */
.links-menu { .links-menu {
position: relative; position: relative;
margin-left: auto; margin-left: auto;
@ -13,8 +9,8 @@
display: flex; display: flex;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
width: 2.75em; width: 2em;
height: 2.75em; height: 2em;
padding: 0; padding: 0;
border: 1px solid transparent; border: 1px solid transparent;
border-radius: 0.4em; border-radius: 0.4em;
@ -47,7 +43,6 @@
display: flex; display: flex;
align-items: center; align-items: center;
gap: 0.5em; gap: 0.5em;
min-height: 2.75em;
padding: 0.4em 0.6em; padding: 0.4em 0.6em;
border-radius: 0.35em; border-radius: 0.35em;
color: var(--fg); color: var(--fg);

View file

@ -2,17 +2,10 @@
renders into. Colour vars come from ../theme.css (same base16 slots renders into. Colour vars come from ../theme.css (same base16 slots
the per-hive dashboard uses, so this reads as recognizably the per-hive dashboard uses, so this reads as recognizably
hyperhive) the layout itself is this package's own, not hyperhive) the layout itself is this package's own, not
@hive/shared's chrome.css. @hive/shared's chrome.css. */
`flex-wrap` on the header and nav rather than a hamburger/collapse
menu: a narrow viewport (phone or a tiled desktop window) wraps onto
a second line instead of overflowing "don't break, don't
over-invest" is the explicit scope here, not full mobile navigation
redesign. */
.shell-header { .shell-header {
display: flex; display: flex;
align-items: center; align-items: center;
flex-wrap: wrap;
gap: 1.5em; gap: 1.5em;
padding: 0.75em 1.25em; padding: 0.75em 1.25em;
border-bottom: 1px solid var(--border); border-bottom: 1px solid var(--border);
@ -25,35 +18,17 @@
} }
.shell-nav { .shell-nav {
display: flex; display: flex;
flex-wrap: wrap;
gap: 1em; gap: 1em;
} }
/* Touch target and active-state underline are deliberately on two
different elements. An earlier version put both `min-height: 2.75em`
and `border-bottom` on the same box: centering the text within a
2.75em box pushes a bottom-edge border ~0.7em away from the text,
which argus caught by actually rendering it a real visual
regression, not just a touch-target win. So: `.shell-nav-link` (the
`<a>`) owns the full-height tappable box (same 2.75em / ~44px WCAG
2.5.5 floor as the rest of the shared kit this is the primary nav,
the single most-clicked/tapped element in the whole shell), and
`.shell-nav-link-text` (an inner span hugging just the text) owns
the underline, so the indicator stays directly under the label
regardless of how tall the tappable box around it is. */
.shell-nav-link { .shell-nav-link {
display: flex;
align-items: center;
min-height: 2.75em;
color: var(--muted); color: var(--muted);
text-decoration: none; text-decoration: none;
padding: 0.25em 0;
border-bottom: 2px solid transparent;
} }
.shell-nav-link:hover { .shell-nav-link:hover {
color: var(--fg); color: var(--fg);
} }
.shell-nav-link-text {
padding-bottom: 0.25em;
border-bottom: 2px solid transparent;
}
.shell-nav-link-active { .shell-nav-link-active {
color: var(--fg); color: var(--fg);
border-bottom-color: var(--purple); border-bottom-color: var(--purple);

View file

@ -34,12 +34,8 @@ const DEFAULT_BRAND = 'hyperhive swarm';
function NavLink({ href, label }: { href: string; label: string }) { function NavLink({ href, label }: { href: string; label: string }) {
const [active] = useRoute(href); const [active] = useRoute(href);
return ( return (
<Link href={href} className="shell-nav-link"> <Link href={href} className={'shell-nav-link' + (active ? ' shell-nav-link-active' : '')}>
{/* Touch target (min-height) lives on the <a> so the whole row is {label}
tappable; the active-state underline lives on this inner span
so it hugs the text instead of sitting at the bottom of the
full-height box, ~0.7em away from it. */}
<span class={'shell-nav-link-text' + (active ? ' shell-nav-link-active' : '')}>{label}</span>
</Link> </Link>
); );
} }

View file

@ -1,8 +1,3 @@
/* Scrolls horizontally within its own box on a narrow viewport instead
of forcing the whole page to overflow see Table.tsx's comment. */
.ui-table-scroll {
overflow-x: auto;
}
.ui-table { .ui-table {
width: 100%; width: 100%;
border-collapse: collapse; border-collapse: collapse;

View file

@ -3,12 +3,6 @@
// their own cell rendering rather than this component knowing about // their own cell rendering rather than this component knowing about
// any particular row shape, so it stays reusable for the swarm-wide // any particular row shape, so it stays reusable for the swarm-wide
// agent roster later without a rewrite. // agent roster later without a rewrite.
//
// Wrapped in a scrollable container rather than letting a wide table
// force the whole page to overflow horizontally on a narrow viewport —
// a `<table>` doesn't shrink below its content's natural width on its
// own, so without this the page itself would break, not just look
// cramped.
import type { ComponentChildren } from 'preact'; import type { ComponentChildren } from 'preact';
import './Table.css'; import './Table.css';
@ -28,25 +22,23 @@ export function Table<T>({
rowKey: (row: T) => string; rowKey: (row: T) => string;
}) { }) {
return ( return (
<div class="ui-table-scroll"> <table class="ui-table">
<table class="ui-table"> <thead>
<thead> <tr>
<tr> {columns.map((c) => (
<th key={c.key}>{c.header}</th>
))}
</tr>
</thead>
<tbody>
{rows.map((row) => (
<tr key={rowKey(row)}>
{columns.map((c) => ( {columns.map((c) => (
<th key={c.key}>{c.header}</th> <td key={c.key}>{c.render(row)}</td>
))} ))}
</tr> </tr>
</thead> ))}
<tbody> </tbody>
{rows.map((row) => ( </table>
<tr key={rowKey(row)}>
{columns.map((c) => (
<td key={c.key}>{c.render(row)}</td>
))}
</tr>
))}
</tbody>
</table>
</div>
); );
} }