vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

hive-forge reaction: add --list-allowed to surface the instance's configured shortcodes

Browse source
This commit is contained in:
damocles 2026-08-18 12:56:54 +02:00 • committed by mara
commit fb9cc5635a
4 changed files with 36 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
hive-forge/src/verbs/issue_cmd.rs
View file

@ -89,7 +89,12 @@ pub fn run(client: &Client, args: Args) -> Result<()> {
verbs::dependency::run(client, a)
}
Cmd::Reaction(a) => {
assert_kind(client, a.number, Kind::Issue)?;
// `--list-allowed` is instance-global, not issue-scoped — skip
// the kind-assert rather than force a real issue number on a
// call that never uses it.
if !a.list_allowed {
assert_kind(client, a.number, Kind::Issue)?;
}
verbs::reaction::run(client, a)
}
Cmd::Timeline(a) => {

7
hive-forge/src/verbs/pr_cmd.rs
View file

@ -113,7 +113,12 @@ pub fn run(client: &Client, args: Args) -> Result<()> {
verbs::dependency::run(client, a)
}
Cmd::Reaction(a) => {
assert_kind(client, a.number, Kind::Pr)?;
// `--list-allowed` is instance-global, not PR-scoped — skip the
// kind-assert rather than force a real PR number on a call that
// never uses it.
if !a.list_allowed {
assert_kind(client, a.number, Kind::Pr)?;
}
verbs::reaction::run(client, a)
}
Cmd::Timeline(a) => {

21
hive-forge/src/verbs/reaction.rs
View file

@ -13,7 +13,12 @@
//! `content` is Forgejo's reaction shortcode vocabulary (`+1`, `-1`,
//! `laugh`, `confused`, `heart`, `hooray`, `rocket`, `eyes`, …), not a
//! raw emoji character — same set the forge web UI's reaction picker
//! offers.
//! offers. `--list-allowed` prints the *actual* instance-configured
//! list (`GET /settings/ui`'s `allowed_reactions`) instead of leaving a
//! caller to guess it or learn it from a 403 — this is instance-global,
//! not issue/PR-scoped, so `number`/`--comment` are ignored when it's
//! set (the number is still required positionally, same as every other
//! generic verb, but unused on this path).
use anyhow::Result;
use clap::{Args as ClapArgs, Subcommand};
@ -24,13 +29,19 @@ use crate::verbs::{comment_reactions, issue_reactions, print_json};
#[derive(ClapArgs)]
pub struct Args {
/// Issue or PR number.
/// Issue or PR number. Ignored (but still required) when
/// `--list-allowed` is set.
pub(crate) number: u64,
/// Target a specific comment's reactions instead of the issue/PR
/// itself — the comment's own id (from `comments`/`comment-show`),
/// not its position in the thread.
#[arg(long)]
comment: Option<u64>,
/// Print the instance's actual configured reaction shortcodes
/// (`GET /settings/ui`) instead of listing/adding/removing —
/// instance-global, ignores `number`/`--comment`.
#[arg(long)]
pub(crate) list_allowed: bool,
#[command(subcommand)]
action: Option<Action>,
}
@ -46,6 +57,12 @@ enum Action {
}
pub fn run(client: &Client, args: Args) -> Result<()> {
if args.list_allowed {
let settings = client.api().get_general_ui_settings().send()?;
return print_json(&serde_json::json!(
settings.allowed_reactions.unwrap_or_default()
));
}
let (owner, name) = client.owner_repo()?;
match args.action.unwrap_or(Action::List) {
Action::List => {}