Watch
0
0
Fork
You've already forked hyperhive
0

review-classifier: narrow tests-with-behaviour to code behaviour, not nix/grafana/log-text

This commit is contained in:
damocles 2026-10-13 14:22:00 +02:00 • committed by mara
commit f6d8dc9d66

View file

@ -33,11 +33,14 @@ classifications:
threshold: 75 threshold: 75
- name: tests-with-behaviour - name: tests-with-behaviour
description: >- description: >-
Every change to how the code behaves comes with a new or updated test Every change to Rust or application code behaviour comes with a new or
that exercises it. A diff whose changed files are all test code updated test that exercises it. A diff whose changed files are all test
(a fixture under `nix/module-eval/`, `nix/checks.nix`, a crate's code (a fixture under `nix/module-eval/`, `nix/checks.nix`, a crate's
`tests/` directory, or Rust inside `#[cfg(test)]` or a `#[test]` `tests/` directory, or Rust inside `#[cfg(test)]` or a `#[test]`
function) changes no behaviour: the question is not applicable. A PR function) changes no behaviour: the question is not applicable. A NixOS
module assertion, a Grafana/alerting rule, or the literal text of a log
or tracing message is not held to this either: none of those are tested
anywhere in this repo today, so the rule doesn't apply to them. A PR
that changes behaviour and tests together matches. that changes behaviour and tests together matches.
polarity: positive polarity: positive
threshold: 65 threshold: 65