review-classifier: narrow tests-with-behaviour to code behaviour, not nix/grafana/log-text
This commit is contained in:
parent
5419d97187
commit
f6d8dc9d66
1 changed files with 7 additions and 4 deletions
|
|
@ -33,11 +33,14 @@ classifications:
|
|||
threshold: 75
|
||||
- name: tests-with-behaviour
|
||||
description: >-
|
||||
Every change to how the code behaves comes with a new or updated test
|
||||
that exercises it. A diff whose changed files are all test code
|
||||
(a fixture under `nix/module-eval/`, `nix/checks.nix`, a crate's
|
||||
Every change to Rust or application code behaviour comes with a new or
|
||||
updated test that exercises it. A diff whose changed files are all test
|
||||
code (a fixture under `nix/module-eval/`, `nix/checks.nix`, a crate's
|
||||
`tests/` directory, or Rust inside `#[cfg(test)]` or a `#[test]`
|
||||
function) changes no behaviour: the question is not applicable. A PR
|
||||
function) changes no behaviour: the question is not applicable. A NixOS
|
||||
module assertion, a Grafana/alerting rule, or the literal text of a log
|
||||
or tracing message is not held to this either: none of those are tested
|
||||
anywhere in this repo today, so the rule doesn't apply to them. A PR
|
||||
that changes behaviour and tests together matches.
|
||||
polarity: positive
|
||||
threshold: 65
|
||||
|
|
|
|||
Loading…
Reference in a new issue