From f45cecf08c81bb230c48adcb2230e96ce7f38c66 Mon Sep 17 00:00:00 2001 From: atlas Date: Tue, 15 Sep 2026 23:11:06 +0200 Subject: [PATCH] ops: address argus review findings on PR #4433 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add attribution-trailer lint row to the ci.md checks table (modeled on the vale-errors row: not yet a required check) so the doc doesn't assert stale completeness once attribution-trailers merges. Delete the dead CI_COMMIT_REF_NAME elif in check-attribution-trailers.sh — byte-identical to the else arm, never exercised, and its comment overclaimed GitLab/Forgejo support nothing here can test. Refs #4432 --- docs/scheduler/ci.md | 17 +++++++++-------- scripts/check-attribution-trailers.sh | 2 -- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/docs/scheduler/ci.md b/docs/scheduler/ci.md index da1b9b57..74196cd5 100644 --- a/docs/scheduler/ci.md +++ b/docs/scheduler/ci.md @@ -41,14 +41,15 @@ gating on the full job's standing warning/suggestion backlog, but flipping that switch on the forge is a separate operator action, not something this table can assert ahead of it happening. -| Job | What it runs | Required? | -| ----------------------------- | ------------------------------------------------------------------------------------------------------- | ------------------------------- | -| **nix flake check** | treefmt formatting, `cargo clippy -D warnings`, `cargo test`, module evaluation | yes | -| **tracker-tag lint** | flags `#NNN` issue tags in source and comments (`scripts/check-issue-refs.sh`) | yes | -| **comment-block lint** | flags contiguous comment blocks over 30 lines (`scripts/check-comment-blocks.sh`) | yes | -| **doc-pointer lint** | flags `docs/…md` paths and relative markdown links that no longer resolve (`scripts/check-doc-refs.sh`) | yes | -| **prose lint (vale, errors)** | vale, `docs/` tree, error-severity rule hits only | not yet — intended to be | -| **prose lint (vale)** | vale, `docs/` tree, full severity range (warnings + suggestions too) | no — advisory, standing backlog | +| Job | What it runs | Required? | +| ----------------------------- | ------------------------------------------------------------------------------------------------------------------------- | ------------------------------- | +| **nix flake check** | treefmt formatting, `cargo clippy -D warnings`, `cargo test`, module evaluation | yes | +| **tracker-tag lint** | flags `#NNN` issue tags in source and comments (`scripts/check-issue-refs.sh`) | yes | +| **comment-block lint** | flags contiguous comment blocks over 30 lines (`scripts/check-comment-blocks.sh`) | yes | +| **doc-pointer lint** | flags `docs/…md` paths and relative markdown links that no longer resolve (`scripts/check-doc-refs.sh`) | yes | +| **attribution-trailer lint** | flags `Co-Authored-By` trailers with Claude/Anthropic attribution in PR commits (`scripts/check-attribution-trailers.sh`) | not yet — intended to be | +| **prose lint (vale, errors)** | vale, `docs/` tree, error-severity rule hits only | not yet — intended to be | +| **prose lint (vale)** | vale, `docs/` tree, full severity range (warnings + suggestions too) | no — advisory, standing backlog | `hive-forge ci-rerun --pr N` dispatches a `workflow_dispatch` retrigger without an empty commit. diff --git a/scripts/check-attribution-trailers.sh b/scripts/check-attribution-trailers.sh index 152ca251..1eb96dbc 100755 --- a/scripts/check-attribution-trailers.sh +++ b/scripts/check-attribution-trailers.sh @@ -12,8 +12,6 @@ set -eu if [ -n "${GITHUB_BASE_REF:-}" ]; then base="origin/${GITHUB_BASE_REF}" -elif [ -n "${CI_COMMIT_REF_NAME:-}" ]; then - base="origin/main" else base="origin/main" fi