vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

frontend: one component = one dir for hive-btn/hive-dialog/hive-toast

Browse source 
Splits the shadow-DOM custom elements out of the flat shared/src layout
into per-component directories:

  hive-btn/hive-btn.{js,css}
  hive-dialog/hive-dialog.{js,css}
  hive-toast/hive-toast.{js,css}

hive-dialog and hive-toast were previously defined inline inside
modal.js alongside the openDialog/themedConfirm/themedPrompt/themedToast
orchestration helpers; modal.js is now a slim entry point that imports
the two component modules for their customElements.define side effect
and keeps only the orchestration functions, which aren't components
themselves. hive-dialog.js now imports hive-btn.js directly (it's the
actual consumer that creates <hive-btn> elements), instead of modal.js
importing it on hive-dialog's behalf.

Pulled the identical shadow-root-plus-adopted-stylesheet boilerplate
(previously duplicated between modal.js's local attachShadow() and
hive-btn.js's inline version) into a shared shadow-css.js helper,
attachShadowCss(host, cssText, shadowInit), used by all three
components. Behaviorally identical — same attachShadow() options per
component, just deduplicated.

No external import paths changed: every consumer only ever imported
the package-level @hive/shared/modal.js entry point, never the
component internals directly, so this is fully internal to the shared
package. Verified with a full frontend build (dashboard + agent
bundles).
This commit is contained in:
iris 2026-07-31 21:29:45 +02:00
commit edf1c5a17f
8 changed files with 172 additions and 169 deletions
Download patch file Download diff file Expand all files Collapse all files

58
frontend/packages/shared/src/hive-btn.js
View file

@ -1,58 +0,0 @@
// hive-btn.js — <hive-btn>, the button primitive for modal.js's dialog
// buttons. Autonomous custom element (previously a customized built-in,
// `<button is="hive-btn">` — dropped: `is=` upgrades can't host a shadow
// root at all, which crashed every themed dialog, and reads as a hack
// regardless once you know that). A real `<button>` lives inside the
// shadow root instead, so native click/keyboard activation and
// `:disabled` still come for free — just one level down from the host.
//
// `delegatesFocus: true` on the shadow root means `.focus()` on the host
// (what modal.js calls) focuses the inner button directly, and a click
// anywhere on the host focuses it too, matching native `<button>` feel.
// The inner button's native `click` is a composed event, so it bubbles
// out through the shadow boundary — callers add `click` listeners on the
// `<hive-btn>` host exactly as they would on a plain `<button>`.
//
// Usage: `el('hive-btn', { type: 'button', variant: 'danger' }, 'label')`.
// `variant` ∈ 'cancel' | 'confirm' | 'danger' | unset (neutral default) —
// reflected straight through to the inner button so hive-btn.css's
// `:host([variant="…"])` selectors keep working unchanged.
// `disabled`/`type` are likewise plain attributes on the host, mirrored
// onto the inner button on connect and on every attribute change.
import hiveBtnCss from './hive-btn.css';
const OBSERVED = ['disabled', 'type'];
class HiveBtn extends HTMLElement {
static get observedAttributes() {
return OBSERVED;
}
connectedCallback() {
if (this._btn) {
this._sync();
return; // already built (e.g. re-parenting re-fires connectedCallback)
}
const root = this.attachShadow({ mode: 'open', delegatesFocus: true });
const sheet = new CSSStyleSheet();
sheet.replaceSync(hiveBtnCss);
root.adoptedStyleSheets = [sheet];
const btn = document.createElement('button');
btn.append(document.createElement('slot'));
root.append(btn);
this._btn = btn;
this._sync();
}
attributeChangedCallback() {
this._sync();
}
_sync() {
if (!this._btn) return;
this._btn.disabled = this.hasAttribute('disabled');
this._btn.type = this.getAttribute('type') || 'button';
}
}
customElements.define('hive-btn', HiveBtn);