vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs(#2363): fix stale 'remap' comments in hive-gateway.nix

Browse source 
The DHCP pool exclusion is now by construction (agent_slots = usable -
dhcpPoolSize), not a secondary-hash remap. Update two comment blocks
that still referenced the old approach.
This commit is contained in:
atlas 2026-07-13 11:05:58 +02:00 • committed by mara
commit eb94b2aae6
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
nix/modules/hive-gateway.nix
View file

@ -13,9 +13,11 @@ let
# DHCP pool for bridge-attached service containers (hive-ci, etc.).
# Occupies the last dhcpPoolSize usable addresses of the subnet
# (e.g. .241-.254 on a /24). Agent containers use deterministic static
# (e.g. .241-.254 on a /24). Agent containers use hash-derived static
# IPs (lifecycle::agent_network_ip) and are excluded from this range
# by a remap in the Rust code.
# by subtracting dhcpPoolSize from the usable count before hashing
# (agent_slots = usable - dhcpPoolSize), so agents only ever land in
# [.2, .(usable-dhcpPoolSize+1)] by construction.
#
# Single source of truth: `nix/dhcp-pool-size` (one integer).
# Rust reads it at compile time via `include_bytes!` in lifecycle/mod.rs.
@ -1035,7 +1037,8 @@ in
# DHCP pool for bridge-attached service containers (hive-ci, etc.).
# Range is computed from the bridgeIp/bridgePrefixLength at eval
# time; the last dhcpPoolSize usable host addresses are reserved.
# Agent containers are excluded by agent_network_ip's DHCP remap.
# Agent containers hash into agent_slots = usable - dhcpPoolSize
# so they never land here (excluded by construction, not remapping).
dhcp-range = "${dhcpStart},${dhcpEnd},1h";
dhcp-leasefile = "/var/lib/dnsmasq/dnsmasq.leases";
};