vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

feat(#1141): pr-reviews list mode shows inline review comments

Browse source
This commit is contained in:
damocles 2026-06-03 14:14:52 +02:00
commit eae124a460
1 changed files with 88 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

106
hive-forge/src/verbs/pr_reviews.rs
View file

@ -65,24 +65,94 @@ pub fn run(client: &Client, args: Args) -> Result<()> {
if args.body.is_some() { if args.body.is_some() {
bail!("--body requires one of --approve / --request-changes / --comment"); bail!("--body requires one of --approve / --request-changes / --comment");
} }
// List mode (original behaviour). // List mode: fetch reviews, then fetch inline comments for each review
let v = client.get_json(&format!("/repos/{repo}/pulls/{}/reviews", args.number))?; // so the full review content is visible without curl fallbacks.
let trimmed: Vec<Value> = v let v =
.as_array() client.get_json(&format!("/repos/{repo}/pulls/{}/reviews", args.number))?;
.map(|a| { let reviews = v.as_array().cloned().unwrap_or_default();
a.iter()
.map(|r| { if client.json_mode() {
json!({ let trimmed: Vec<Value> = reviews
"id": r.get("id"), .iter()
"state": r.get("state"), .map(|r| {
"user": r.get("user").and_then(|u| u.get("login")), let id = r.get("id").and_then(Value::as_u64).unwrap_or(0);
"body": r.get("body"), let inline = if id > 0 {
"comments_count": r.get("comments_count"), client
}) .get_json(&format!(
"/repos/{repo}/pulls/{}/reviews/{id}/comments",
args.number
))
.ok()
.and_then(|v| v.as_array().cloned())
.map(|comments| {
comments
.iter()
.map(|c| {
json!({
"id": c.get("id"),
"path": c.get("path"),
"line": c.get("line"),
"body": c.get("body"),
})
})
.collect::<Vec<_>>()
})
.unwrap_or_default()
} else {
vec![]
};
json!({
"id": r.get("id"),
"state": r.get("state"),
"user": r.get("user").and_then(|u| u.get("login")),
"body": r.get("body"),
"comments_count": r.get("comments_count"),
"comments": inline,
}) })
.collect() })
}) .collect();
.unwrap_or_default(); print_json(&Value::Array(trimmed))
print_json(&Value::Array(trimmed)) } else {
if reviews.is_empty() {
println!("(no reviews)");
return Ok(());
}
for r in &reviews {
let id = r.get("id").and_then(Value::as_u64).unwrap_or(0);
let user = r
.get("user")
.and_then(|u| u.get("login"))
.and_then(Value::as_str)
.unwrap_or("?");
let state = r.get("state").and_then(Value::as_str).unwrap_or("?");
let body = r.get("body").and_then(Value::as_str).unwrap_or("").trim();
println!("### review by {user} ({state})");
if !body.is_empty() {
println!("{body}");
}
// Fetch and print inline comments for this review.
if id > 0 {
if let Ok(ic) = client.get_json(&format!(
"/repos/{repo}/pulls/{}/reviews/{id}/comments",
args.number
)) {
let inline = ic.as_array().cloned().unwrap_or_default();
for c in &inline {
let path = c.get("path").and_then(Value::as_str).unwrap_or("?");
let line = c
.get("line")
.and_then(Value::as_u64)
.map(|n| n.to_string())
.unwrap_or_else(|| "?".to_string());
let cbody =
c.get("body").and_then(Value::as_str).unwrap_or("").trim();
println!(" [{path}:{line}] {cbody}");
}
}
}
println!();
}
Ok(())
}
} }
} }