fix: address argus+mara review on #1243 — stale docs, MANAGER_DEFAULT refs, ruth migration

This commit is contained in:
damocles 2026-06-04 11:39:01 +02:00 committed by mara
commit e58ead4329
7 changed files with 64 additions and 37 deletions

View file

@ -802,8 +802,8 @@ pub struct SchedulePromptPayload {
/// `HIVE_TOOL_GROUPS` from the environment (a comma-separated list of
/// `snake_case` group names written by the meta renderer from per-agent
/// config) and expands it to the matching tool names for `--allowedTools`.
/// When the env var is absent the harness falls back to the flavor default
/// (`AGENT_DEFAULT` or `MANAGER_DEFAULT`). See `docs/conventions.md::Tool groups`.
/// When the env var is absent the harness falls back to `AGENT_DEFAULT`.
/// See `docs/conventions.md::Tool groups`.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum ToolGroup {
@ -878,13 +878,12 @@ impl ToolGroup {
}
}
/// Default tool groups for a plain agent harness — equivalent to the
/// old `Flavor::Agent` allow-list. Used when `HIVE_TOOL_GROUPS` is unset.
/// Default tool groups for an agent harness. Used when `HIVE_TOOL_GROUPS` is unset.
pub const AGENT_DEFAULT: &'static [Self] =
&[Self::Messaging, Self::Meta, Self::Inbox, Self::Execution];
/// Default tool groups for the manager harness — equivalent to the
/// old `Flavor::Manager` allow-list. Used when `HIVE_TOOL_GROUPS` is unset.
/// Convenience preset for a fully-privileged agent (all groups).
/// Use this as a starting point in `tool-groups.json` for root/manager agents.
pub const MANAGER_DEFAULT: &'static [Self] = &[
Self::Messaging,
Self::Meta,