From e334513244d730c37fe0f87785fdb6855c48cb3c Mon Sep 17 00:00:00 2001 From: damocles Date: Sun, 1 Nov 2026 02:05:31 +0100 Subject: [PATCH] forge notify docs: rewrite the inline comments section for the prose lint --- docs/integrations/forge.md | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/docs/integrations/forge.md b/docs/integrations/forge.md index 74f2d165..1eda1507 100644 --- a/docs/integrations/forge.md +++ b/docs/integrations/forge.md @@ -301,22 +301,24 @@ with the meta-suffix `reviewer:` line (requested reviewers, below). ### Inline review comments A review's line comments belong to neither the review body nor the -`latest_comment_url` (a review with only inline comments has no such url -and otherwise lands as a bare `activity on PR`). So every PR wake fetches -the PR's reviews (`/pulls/N/reviews`, up to four pages of 50) and, for the -reviews new to the agent, appends an +`latest_comment_url`. A review with only inline comments has no such url +and would otherwise land as a bare `activity on PR`. Every PR wake therefore +fetches the PR's reviews (`/pulls/N/reviews`, up to four pages of 50) and, +for the reviews new to the agent, appends an `inline review comments (read them with `hive-forge pr reviews N`):` block -saying where they are: one `author: path:line, path, ...` line per review +saying where they sit: one `author: path:line, path, ...` line per review author (bare `path` when Forgejo dropped the position because the line left the diff; control characters in a path become spaces). The comment text stays -out of the wake - the agent reads the full review with the CLI. A review -counts as new when it was submitted strictly after the thread's previously -delivered `updated_at` (all of them without a baseline, and any with no -submit time, so nothing is hidden), is not the agent's own, is not a -`PENDING` draft, and has `comments_count > 0`. Only the newest 5 such reviews -are fetched and at most 10 locations are listed (`(+N more)` for the rest). -Best effort: a failed fetch yields less text, never a dropped wake. Cost: one -reviews fetch per PR wake, plus one per new commented review. +out of the wake, and the agent reads the full review with the CLI. + +A review counts as new when it landed strictly after the thread's previously +delivered `updated_at`. Without a baseline every review counts, and so does +one with no submit time, so nothing disappears. It doesn't count when the +agent wrote it, when it's a `PENDING` draft, or when `comments_count` is 0. +The notifier fetches the newest 5 such reviews and lists at most 10 locations +(`(+N more)` for the rest). Best effort: a failed fetch yields less text and +never drops the wake. Cost: one reviews fetch per PR wake, plus one per new +commented review. ### Merge/close vs a later comment