From d494413c7fd2b3ed34a8a7dc6c86d7eb189a1fe7 Mon Sep 17 00:00:00 2001 From: lexis Date: Tue, 26 May 2026 00:14:57 +0200 Subject: [PATCH] docs: clarify approval row is marked failed, not absent, on flake validation failure --- docs/approvals.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/approvals.md b/docs/approvals.md index 2a604632..7f5149aa 100644 --- a/docs/approvals.md +++ b/docs/approvals.md @@ -30,8 +30,10 @@ happens after a decision lands. applied. 3a. **Flake validation (ApplyCommit only):** after the proposal tag is planted, hive-c0re reads `proposal/:flake.lock` and - runs two checks (closes #317). The request is rejected (no - approval row created) if either fails: + runs two checks (closes #317). If either check fails, no + pending approval is created for the operator — the row is + marked failed and surfaces on the dashboard with the + validation message: - **Stale lock** — materialises the commit in a temp worktree, runs `nix flake lock` (no `--update-input` flags, so it only fills missing entries), and rejects if the committed