vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(#2327): handle dismissed reviews like stale (superseded helper)

Browse source
This commit is contained in:
damocles 2026-07-10 15:15:05 +02:00 • committed by mara
commit ce909a00a2
3 changed files with 38 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

6
hive-forge/src/verbs/pr_merge.rs
View file

@ -157,12 +157,12 @@ fn check_ready(client: &Client, repo: &str, number: u64, pull: &PullRequest) ->
// Block only on reviewers whose *current* verdict requests changes
// (latest-per-reviewer, so a later APPROVED clears an earlier
// REQUEST_CHANGES). A stale REQUEST_CHANGES was made against an older
// head and no longer applies, so it doesn't block. Shares the verdict
// REQUEST_CHANGES). A superseded REQUEST_CHANGES — stale (older head) or
// dismissed — no longer applies, so it doesn't block. Shares the verdict
// logic with `pr-status`.
let blockers: Vec<String> = super::latest_reviews(client, repo, number)?
.into_iter()
.filter(|r| r.state == "REQUEST_CHANGES" && !r.stale)
.filter(|r| r.state == "REQUEST_CHANGES" && !r.superseded())
.map(|r| r.login)
.collect();
if !blockers.is_empty() {