fix(dashboard): render update_meta_inputs + schedule_prompt approval cards
Both kinds fell through to the spawn branch in renderApprovals, showing a misleading 'spawn' chip and agent-spawn body text. Mara saw a meta-input bump render as a spawn card for agent damocles and denied it. Backend (dashboard.rs): - Add commit_ref: None to the MergeConfigPr arm (struct was incomplete). All arms of ApprovalView now initialise every field. Frontend (call.js): - Add isUpdateMeta / isSchedule booleans alongside the existing kind flags. - Glyph: update_meta_inputs gets ↻, schedule_prompt gets ⏱. - Kind chip: 'meta-update' / 'schedule' (no kind-spawn class for either). - Body: update_meta_inputs parses commit_ref as JSON Vec<String> and shows 'bump flake inputs: foo, bar' or 'bump all flake inputs'; schedule_prompt parses SchedulePromptPayload and shows targets + first-fire time + cadence + a truncated body excerpt. - History row: add 'meta-update' and 'schedule' cases (were both 'spawn'). - Import fmtDuration from util.js (needed for schedule cadence display).
This commit is contained in:
parent
5972605aeb
commit
c65201ed7c
2 changed files with 42 additions and 5 deletions
|
|
@ -448,6 +448,13 @@ struct ApprovalView {
|
|||
/// sha. `None` for every other kind.
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
pr_number: Option<u64>,
|
||||
/// Raw `commit_ref` payload for `UpdateMetaInputs` (JSON-encoded
|
||||
/// `Vec<String>` of input names; `"[]"` = all inputs) and
|
||||
/// `SchedulePrompt` (JSON-encoded `SchedulePromptPayload`). The
|
||||
/// frontend parses this to render a human-readable card body.
|
||||
/// `None` for every other kind.
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
commit_ref: Option<String>,
|
||||
/// Unix seconds the approval was queued. Rendered as a relative
|
||||
/// time on the card so the operator can spot a stale request.
|
||||
requested_at: i64,
|
||||
|
|
@ -909,6 +916,7 @@ async fn build_approval_views(approvals: Vec<Approval>) -> Vec<ApprovalView> {
|
|||
diff: Some(diff),
|
||||
description: a.description,
|
||||
pr_number: None,
|
||||
commit_ref: None,
|
||||
requested_at: a.requested_at,
|
||||
}
|
||||
}
|
||||
|
|
@ -920,6 +928,7 @@ async fn build_approval_views(approvals: Vec<Approval>) -> Vec<ApprovalView> {
|
|||
diff: None,
|
||||
description: a.description,
|
||||
pr_number: None,
|
||||
commit_ref: None,
|
||||
requested_at: a.requested_at,
|
||||
},
|
||||
hive_sh4re::ApprovalKind::InitConfig => ApprovalView {
|
||||
|
|
@ -930,6 +939,7 @@ async fn build_approval_views(approvals: Vec<Approval>) -> Vec<ApprovalView> {
|
|||
diff: None,
|
||||
description: a.description,
|
||||
pr_number: None,
|
||||
commit_ref: None,
|
||||
requested_at: a.requested_at,
|
||||
},
|
||||
hive_sh4re::ApprovalKind::UpdateMetaInputs => ApprovalView {
|
||||
|
|
@ -940,6 +950,7 @@ async fn build_approval_views(approvals: Vec<Approval>) -> Vec<ApprovalView> {
|
|||
diff: None,
|
||||
description: a.description,
|
||||
pr_number: None,
|
||||
commit_ref: Some(a.commit_ref),
|
||||
requested_at: a.requested_at,
|
||||
},
|
||||
hive_sh4re::ApprovalKind::SchedulePrompt => ApprovalView {
|
||||
|
|
@ -950,6 +961,7 @@ async fn build_approval_views(approvals: Vec<Approval>) -> Vec<ApprovalView> {
|
|||
diff: None,
|
||||
description: a.description,
|
||||
pr_number: None,
|
||||
commit_ref: Some(a.commit_ref),
|
||||
requested_at: a.requested_at,
|
||||
},
|
||||
hive_sh4re::ApprovalKind::MergeConfigPr => {
|
||||
|
|
@ -971,6 +983,7 @@ async fn build_approval_views(approvals: Vec<Approval>) -> Vec<ApprovalView> {
|
|||
diff: None,
|
||||
description: a.description,
|
||||
pr_number,
|
||||
commit_ref: None,
|
||||
requested_at: a.requested_at,
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue