From c4d239145535fd3d860546a8838deea0c7245513 Mon Sep 17 00:00:00 2001 From: atlas Date: Sat, 11 Jul 2026 10:54:33 +0200 Subject: [PATCH] fix(review): drop libnull.rlib artifact + add Errors doc to ensure_config_pr_webhook - Remove libnull.rlib accidentally committed in previous push (cargo check --no-default-features side-effect); add *.rlib to .gitignore to prevent recurrence - Add # Errors section to ensure_config_pr_webhook doc comment (argus: missing on pub async fn returning Result<()>) --- .gitignore | 1 + hive-c0re/src/forge/mod.rs | 12 ++++++++++++ libnull.rlib | Bin 5442 -> 0 bytes 3 files changed, 13 insertions(+) delete mode 100644 libnull.rlib diff --git a/.gitignore b/.gitignore index a4afea36..b7ce58d6 100644 --- a/.gitignore +++ b/.gitignore @@ -3,3 +3,4 @@ /result-* /.tmp /.claude/settings.local.json +*.rlib diff --git a/hive-c0re/src/forge/mod.rs b/hive-c0re/src/forge/mod.rs index 3a98c5f4..b7c6c770 100644 --- a/hive-c0re/src/forge/mod.rs +++ b/hive-c0re/src/forge/mod.rs @@ -307,6 +307,18 @@ pub async fn ensure_all() { /// /// Called at startup alongside `knowledge::ensure_webhook`. No-op when the /// core token is absent (forge not yet provisioned). +/// +/// # Errors +/// +/// Returns an error if: +/// - `dashboard_port` produces a URL that `url::Url::parse` rejects (should +/// never happen for a valid port number). +/// - The Forgejo `org_create_hook` API call fails (transport error, auth +/// failure, or the `agent-configs` org does not exist). +/// - The HTTP call times out (10 s limit). +/// +/// Listing failures are treated as best-effort: they fall through to the +/// create attempt rather than surfacing an error. pub async fn ensure_config_pr_webhook(core_token: &str, dashboard_port: u16) -> Result<()> { use forgejo_api::structs::{CreateHookOption, CreateHookOptionConfig, CreateHookOptionType}; use std::collections::BTreeMap; diff --git a/libnull.rlib b/libnull.rlib deleted file mode 100644 index a6c2cdcfcb983f046bfa6f83da250d6b7aab7a38..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 5442 zcmY$iNi0gvu;bEKKm`U!TnHPPR8X*h%O`L#K!HBGA#gR=874+B@dU2C(wrPUFkxY6 zmSmb}X=$09VwRX@0GaVS%7+4ut7#J7?7#J8>85kJc z{X!X-7#I$K#F)Wq7#NC5i%S?77`WDf6fiI_ID!O{6%6$(P4x^EG)yfm49v|8%~BPN z42;Zl4NPIlIYb*Pm^tyvB z%X#;!NVlM;UJOivy2+MCi3TYtDXGau7A9%tX$KjYezVLzIH^xU@4#!@B zH?T-fGC9b=w25W)zxZX|+TZ@}^UOG)$&)n=q|m^~z|=4?(KIQ|!qULp!2BR1(+rLi z_f*8J&*{v#P`U81_rG-!AcZDr$)<*uiHT{crp8I87KR5I7$m>}5?@@B5?`KQlwDkq zn4B7)oL`iBP?uY}OYzl`Z~wA2@~^I0wF_i`d2&)pqDitrlA)P_Ws0ToK?bHt0*t2> zRh1fl-HZBn?B$QX)9xUJ2B{{gDan?phUST>W~Rxe2N@Z-b2IZYtK#!3GE-6yK4R8= za;K{&sZ*h?yx~jBCXgO;qom{{W5d)GgXCljGb7`Jj0|jvDLJV{MhAn7wh5c2GN(@1 zv@MXMzf2LNJjLA1ASJ~p#l$cr%{VP3`5+?$XGUUiMp99JdEUXm>M*lg?iIo2*JGdG zzs8;c(qV34YHDdTO=B!fdV5rEj>On?cnN0D2ow;4MLtj+OEe50`DLF04$js2lBGJIm+#o{?EiJ_;$=D*1DGTIj zhAo!$-?m@q`&0Be)QjB`?0SPlW8-AgR1-^M^R(1tOG}XJb5nDZGl~w@D%?&fobYb_ zwVfOF=lH!m12Wwp$HOM@i8%iL_h=+10x#)14xWt1WAlv zkzbi#wS4WhIWwcO8x@=_{VreXn4yyBbi{4-jK|E3EDQ`R%nU4yffP#4lm(xJnVV(s! z6U4`cVXnm{N3Pia|Nnjd|1bRi-{C(Dpzs+aDlE+6%}jJl^Rn~u%ky+|GV@9+bkp-n z4?f8@iTLVO`+2|nyQus~6&I$-pjz%A!j+IP6TS@+MseRUMAg9oQY3*Q3*&&J5+n^1 z0MX2h49two3}AwZk(r5^iHV7g0bJ>Tq-lvk$rx0df$U%cxeJt(K^$T+6O%s^6AKd) z3kw576C$EPMUQT3UW#s7W=<+Tv-I-vOH%dH^Gfv!it-Cmi%KdP^olczONvSolNj{i zbY(7>53c|58AqfXDAgk33!w>8=QA)UAcVjy4ls!z^cX-n9n5b4lTac7O3R@c4zdp_ z1*X(MSq;oWB^sdmV2KCR#sKMs*$)$!V_;wa#TKe=28J0>{UANaa_D>!9QtQM^_wDV zM)(yjst;*uf!kRi0+|b8Lr8dA%-jqjKtfyW1kBS63=EKXabVzJU}SJ|K5)-e1kx5u z;xSP1irlv>_V?EF+<^@~Ab%?IFfeRnWMJTCQUs@LB?blt_D1E2jwe_=*#wL%Co#70 zsIqcM%CU4OHE_5xIZfhrauF~RvEY#K<}y<1@Ys-|=-k%9;x1$4q*8c-Lr_K2p{+;2 zo6#txg=3P8g0fS`QwB*vCl*O94Xp`*F$&5%9ol##53`>Zl~n5KQDK)fO46}BF+ouI zgir^ctW}DO`w0OhXE!EEDTYo31_n+B1_q@x7J*GpO`QTkPEDN?3J(Q%aB-?R9bdra+^jJ#tjGEnBk3HYTt+vr|fkqAkgM%0c0|Tf;F_N3XAt~rHp@&n={TPe$Duu2E zprp;PQG$WtGy?;JF-L>Uk%uyAB8;{j&K50)dz>2BD=XNGXB6^0W8i-)!1twr&zQ$a z?$ANma|>nC3|PU+nx)S$+n#W??P0b(Q_)jWz+TP4Ug^=%O2K;#j{Et8IeF)$)7C0h%Pf_NEqU@nWxio`L>pjiZ7o07(Fx%{DwrOFuKJ!7O zEP=f`gWWu%y(oj-yrI2dLVH01dzl7%*$>vTiuUq`_IQr=LW%aG8SRxb8g<@%;CuIg z@9P1+HwMf}Cl<;)StxS`Ox{V9Ii)Cbq*3-%BHOhI&Xy;fEoXqq9fvKZI9qfuTTeNx zzo*&ePm}c(X6p@yd5&kc7eurd6*QM*uva9smq@giENGWJ7tH^Tf&Wtg-;)V^j~)0Q zD)7At;4@axkiBzI?vSJ0B}JJ#jdFJ$$UJ!{`-)L6O(M`@gR|9~X6rKnDo~Fkw3k<~ zSIh|X`7(hY6asQta;FkyUMR}mJ1ASnCs#x1OCqs*j_&1dlJC+!$A4bn?#vIjj}f$ioa2m zeWoaTL{avJqU;Mr`80*O)_a_7cQ9K{X|_BQv8SMby}W|Gii5q%qrJSKUGnsEzV`zV{0J?;o(e58(e|!2i;L@96`! zXA1leFYrAzSnSYTmcd@h(JmPzwd1gL3$yhSXNxn<(k;xE6Pj(#Fx#{owwMAg@+%b> z7>pSh7$(ViC^&cUNOGp6oH(h_*u!Gv=H@2c=(J$M$0H{=ES=hV9yzoyGccT-#KjQc z>8#+BT9%p?jHiGqLUTMQj3Z+^YbX_sxmMzD046xGzqXMb2J(pc3?Tm zz`Cd)J)l&6@)1h_94j zV9;e?VBqE|(r7PlV6TcOnBi=@0~8&W7Y;W)lR37K_k|-U`#%FkIw;+WnLJM5dmh05 zP=WsmC{yr158(Tl@CNCk|UqX}0ch zw(McHJ;7`Zst_*-XXPhqxQ&}=is*xmZrO3sBUpdVsbWv zUQSL~ZgOr4gprht(b^=!ix_s2AYh224VD3I_r#)^1xh=}LLfc}gW?%k9MV=o7J;xq zX$``Hkebl+!@$6R(uRfUUjc0kLR7=syD%=ejSR9MUH=O-eJ~ABwJw^Q3NwK6 H6i77y_?zfR