refactor(#2416): remove the non-pr config-change flow (request_apply_commit / applycommit)

hive-c0re/src/dashboard_events.rs

@@ -62,11 +62,10 @@ pub enum DashboardEvent {
     },
     /// A new approval landed in the pending queue. Payload carries
     /// enough to render the dashboard row without a `/api/state`
-    /// refetch (`diff` is the raw unified diff text, same shape the
-    /// snapshot ships).
+    /// refetch.
     ///
-    /// The approval's own kind (`"apply_commit"` / `"spawn"`) lives on
-    /// `approval_kind` rather than `kind` because the latter is taken
+    /// The approval's own kind (`"merge_config_pr"` / `"spawn"`) lives
+    /// on `approval_kind` rather than `kind` because the latter is taken
     /// by the serde tag identifying which `DashboardEvent` variant
     /// this is.
     ApprovalAdded {
@@ -75,7 +74,6 @@ pub enum DashboardEvent {
         agent: String,
         approval_kind: &'static str,
         sha_short: Option<String>,
-        diff: Option<String>,
         description: Option<String>,
         /// Forge PR number, for `merge_config_pr` approvals only — lets
         /// the live `applyApprovalAdded` path build the "review PR on
@@ -350,9 +348,8 @@ mod tests {
                 seq: 1,
                 id: 1,
                 agent: "x".into(),
-                approval_kind: "apply_commit",
+                approval_kind: "merge_config_pr",
                 sha_short: None,
-                diff: None,
                 description: None,
                 pr_number: None,
             },
@@ -360,7 +357,7 @@ mod tests {
                 seq: 1,
                 id: 1,
                 agent: "x".into(),
-                approval_kind: "apply_commit",
+                approval_kind: "merge_config_pr",
                 sha_short: None,
                 status: "approved",
                 resolved_at: hive_sh4re::wire_time::from_secs(0),