swarm-required-services: trim otel.enable comment per review
This commit is contained in:
parent
89e8600ba8
commit
bfc0d86684
1 changed files with 2 additions and 12 deletions
|
|
@ -72,17 +72,7 @@ in
|
||||||
grafana.enable = lib.mkDefault swarmCfg.enableRequiredServices;
|
grafana.enable = lib.mkDefault swarmCfg.enableRequiredServices;
|
||||||
};
|
};
|
||||||
|
|
||||||
# The collector that feeds the pair above. Missed for the same reason
|
# The collector that feeds the pair above (note: no `swarm.` prefix,
|
||||||
# `nats.enable` was above (found while investigating why grafana showed
|
# this is ./otel.nix's existing per-hive option).
|
||||||
# nothing on a swarm-services host): `otel.nix` predates this file's
|
|
||||||
# last revisit, so its absence here was omission, not intent — a
|
|
||||||
# swarm-services host otherwise gets victoriametrics + grafana running
|
|
||||||
# with nothing feeding them until an operator flips `otel.enable` by
|
|
||||||
# hand. `services.hyperhive.otel` (note: no `swarm.` prefix, this is the
|
|
||||||
# existing per-hive option from ./otel.nix, not a new swarm-scoped one)
|
|
||||||
# already treats a co-located `swarm.victoriametrics.enable` as a
|
|
||||||
# complete destination with no `endpoint` required (see that module's
|
|
||||||
# own history), so this default is self-sufficient on exactly the host
|
|
||||||
# it fires on.
|
|
||||||
config.services.hyperhive.otel.enable = lib.mkDefault swarmCfg.enableRequiredServices;
|
config.services.hyperhive.otel.enable = lib.mkDefault swarmCfg.enableRequiredServices;
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue