hive-priv, hive-c0re: two more doc comments describing the deleted branch
set_nspawn_flags said PRIVATE_NETWORK was forced 0 for web-UI
reachability; it is now unconditionally 1 and the UI is reached over the
bridge. write_bridge_dns_marker said it writes or removes the marker;
the removal path went with the host-netns case.
Neither was reachable by the sweeps that found the earlier ones: this
prose describes the *value in words* ('forced 0'), not the code's
literal PRIVATE_NETWORK=0, and neither names the env var. Found by
reading the doc comment of every function whose body this branch
changed.
This commit is contained in:
parent
aaf55b9c27
commit
bb732a106c
2 changed files with 10 additions and 6 deletions
|
|
@ -131,9 +131,12 @@ fn bind_child_agent_dirs(child: &str, binds: &mut Vec<BindMount>) {
|
|||
}
|
||||
|
||||
/// Idempotently rewrite the lines in `/etc/nixos-containers/<container>.conf`
|
||||
/// that hive-c0re owns: `PRIVATE_NETWORK` (forced 0 so the agent's web UI port
|
||||
/// is reachable on the host) and `EXTRA_NSPAWN_FLAGS` (the runtime-dir bind).
|
||||
/// The start script expands `$EXTRA_NSPAWN_FLAGS` unquoted into the
|
||||
/// that hive-c0re owns: `PRIVATE_NETWORK` (always 1 — every container runs in
|
||||
/// its own network namespace with a veth on the host bridge, and the agent's
|
||||
/// web UI is reached over that bridge rather than a host-shared netns),
|
||||
/// `HOST_ADDRESS` (the bridge gateway IP, so the container installs a default
|
||||
/// route before DHCP completes) and `EXTRA_NSPAWN_FLAGS` (the runtime-dir
|
||||
/// bind). The start script expands `$EXTRA_NSPAWN_FLAGS` unquoted into the
|
||||
/// `systemd-nspawn` command.
|
||||
#[allow(
|
||||
clippy::too_many_lines,
|
||||
|
|
|
|||
Loading…
Reference in a new issue