refactor(#2862): one snapshot store per swarm, not one per peer
The push side modelled a store per peer hive: a --peer argument, a swarm.peers.<domain>.snapshotStorePort option, and a swarm_peers module whose entire job was answering "which peer". A swarm has exactly one store, so none of that had anything to select between. The receiver already proved it. It keys destination directories by agent, not by sending hive, precisely so an agent that migrates keeps one unbroken incremental chain -- which only makes sense if every hive pushes to the same place. Per-hive stores would split the chain in two, the case that keying exists to prevent. So the destination moves to services.hyperhive.swarm.snapshotStore, rendered into HYPERHIVE_SNAPSHOT_STORE, and swarm_peers is deleted rather than adapted. address has no default because it is a deployment fact this host cannot derive; port defaults because it is a convention both ends read from the same option docs. An unset or empty address fails naming the option instead of connecting somewhere arbitrary, and a test asserts the message suggests no value.
This commit is contained in:
parent
258c0998ab
commit
ba71e45486
9 changed files with 171 additions and 279 deletions
|
|
@ -268,8 +268,7 @@ async fn dispatch(req: &HostRequest, coord: Arc<Coordinator>) -> HostResponse {
|
|||
name,
|
||||
label,
|
||||
parent,
|
||||
peer,
|
||||
} => handle_push_snapshot(name.as_str(), label, parent.as_deref(), peer).await?,
|
||||
} => handle_push_snapshot(name.as_str(), label, parent.as_deref()).await?,
|
||||
})
|
||||
}
|
||||
.await;
|
||||
|
|
@ -667,18 +666,17 @@ async fn handle_send_snapshot(
|
|||
Ok(HostResponse::messages(vec![path]))
|
||||
}
|
||||
|
||||
/// Push a snapshot to a peer hive's store. The network sibling of
|
||||
/// Push a snapshot to the swarm's store. The network sibling of
|
||||
/// [`handle_send_snapshot`]: nothing lands on this host, so success is
|
||||
/// bare rather than a path.
|
||||
async fn handle_push_snapshot(
|
||||
name: &str,
|
||||
label: &str,
|
||||
parent: Option<&str>,
|
||||
peer: &str,
|
||||
) -> Result<HostResponse> {
|
||||
crate::snapshot_push::push_agent_snapshot(name, label, parent, peer)
|
||||
crate::snapshot_push::push_agent_snapshot(name, label, parent)
|
||||
.await
|
||||
.with_context(|| format!("push {name} snapshot (label {label:?}) to peer {peer:?}"))?;
|
||||
.with_context(|| format!("push {name} snapshot (label {label:?}) to the swarm store"))?;
|
||||
Ok(HostResponse::success())
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue