refactor(#1141): split list_reviews into list_reviews_json + list_reviews_text
This commit is contained in:
parent
374e53d13e
commit
aa91d0d30d
1 changed files with 78 additions and 58 deletions
|
|
@ -87,13 +87,25 @@ fn fetch_inline_comments(client: &Client, repo: &str, pr: u64, review_id: u64) -
|
||||||
.unwrap_or_default()
|
.unwrap_or_default()
|
||||||
}
|
}
|
||||||
|
|
||||||
/// List all reviews for a PR, including inline diff comments per review.
|
/// List all reviews for a PR, dispatching to the appropriate output mode.
|
||||||
fn list_reviews(client: &Client, number: u64) -> Result<()> {
|
fn list_reviews(client: &Client, number: u64) -> Result<()> {
|
||||||
let repo = client.repo();
|
let repo = client.repo();
|
||||||
let v = client.get_json(&format!("/repos/{repo}/pulls/{number}/reviews"))?;
|
let v = client.get_json(&format!("/repos/{repo}/pulls/{number}/reviews"))?;
|
||||||
let reviews = v.as_array().cloned().unwrap_or_default();
|
let reviews = v.as_array().cloned().unwrap_or_default();
|
||||||
|
|
||||||
if client.json_mode() {
|
if client.json_mode() {
|
||||||
|
list_reviews_json(client, repo, number, &reviews)
|
||||||
|
} else {
|
||||||
|
list_reviews_text(client, repo, number, &reviews)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// JSON output: one object per review, with an inline `comments` array.
|
||||||
|
fn list_reviews_json(
|
||||||
|
client: &Client,
|
||||||
|
repo: &str,
|
||||||
|
number: u64,
|
||||||
|
reviews: &[Value],
|
||||||
|
) -> Result<()> {
|
||||||
let trimmed: Vec<Value> = reviews
|
let trimmed: Vec<Value> = reviews
|
||||||
.iter()
|
.iter()
|
||||||
.map(|r| {
|
.map(|r| {
|
||||||
|
|
@ -124,12 +136,21 @@ fn list_reviews(client: &Client, number: u64) -> Result<()> {
|
||||||
})
|
})
|
||||||
.collect();
|
.collect();
|
||||||
print_json(&Value::Array(trimmed))
|
print_json(&Value::Array(trimmed))
|
||||||
} else {
|
}
|
||||||
|
|
||||||
|
/// Human-readable output: Markdown-style heading per review, inline
|
||||||
|
/// comments as `[path:line] body` (line omitted for PR-level comments).
|
||||||
|
fn list_reviews_text(
|
||||||
|
client: &Client,
|
||||||
|
repo: &str,
|
||||||
|
number: u64,
|
||||||
|
reviews: &[Value],
|
||||||
|
) -> Result<()> {
|
||||||
if reviews.is_empty() {
|
if reviews.is_empty() {
|
||||||
println!("(no reviews)");
|
println!("(no reviews)");
|
||||||
return Ok(());
|
return Ok(());
|
||||||
}
|
}
|
||||||
for r in &reviews {
|
for r in reviews {
|
||||||
let id = r.get("id").and_then(Value::as_u64).unwrap_or(0);
|
let id = r.get("id").and_then(Value::as_u64).unwrap_or(0);
|
||||||
let user = r
|
let user = r
|
||||||
.get("user")
|
.get("user")
|
||||||
|
|
@ -157,4 +178,3 @@ fn list_reviews(client: &Client, number: u64) -> Result<()> {
|
||||||
}
|
}
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
}
|
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue