swarm ui: one review page
The two review tabs, runs and try-out, are one: /review. It is a column of three sections: try a classification and the classifier settings, each a folded bar (the settings' bar says what they are now), then the recent runs, always open. The settings had been pinned under the try-out form; they are now a section of their own. A new Disclosure primitive is the folding bar, a native details wearing the Panel's classes, so the folded and open sections read as the same surface. /review-runs and /review-tryout are gone, with no redirect.
This commit is contained in:
parent
7b1435eaea
commit
a68d73fa74
19 changed files with 223 additions and 45 deletions
|
|
@ -232,7 +232,7 @@ key.
|
|||
|
||||
A dedicated forge user, separate from swarm-controller's site-admin account
|
||||
and from every agent's account. It's the reviewer someone requests, it
|
||||
authors every classifier review, and it pushes the branches the try-out page
|
||||
authors every classifier review, and it pushes the branches the try-out section
|
||||
creates.
|
||||
|
||||
`swarm-controller` creates it as `review-classifier`, with the email
|
||||
|
|
@ -256,7 +256,7 @@ collaborator:
|
|||
allowlist, the account counts only once it's on that list, and read access
|
||||
is then enough for reviews.
|
||||
|
||||
The try-out page's **open a PR** pushes a branch to the repo itself, so it
|
||||
The try-out's **open a PR** pushes a branch to the repo itself, so it
|
||||
needs **write** whatever the branch protection says.
|
||||
|
||||
The repo also needs a rules file on its default branch (see
|
||||
|
|
|
|||
Loading…
Reference in a new issue