vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Activity

swarm-ui: try-out rows keyed by position, distinct names, and accurate storage wording

Browse source 
Two classifications sharing a name made the result table's row key collide, so the form now refuses duplicate names and the table keys rows by position anyway. The page said it stores nothing in the browser, but the result table remembers its column filters like every table does; the header comment and the docs now say that. The row cap's comment says to keep it in step with the endpoint's own cap.
This commit is contained in:
iris 2026-10-12 01:08:58 +02:00 • committed by mara
commit a4a4381cf6
1 changed files with 26 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
frontend/packages/swarm-ui/src/pages/review-tryout/ReviewTryOutPage.tsx
View file

@ -7,8 +7,9 @@
// `failed`. A run takes a minute or more, so the page says it is running.
//
// The inputs stay as typed after a run, so the operator can edit and run
// again. The page stores nothing (not even in the browser) and posts nothing
// to the forge.
// again. The page keeps nothing you typed and no result, and posts nothing to
// the forge; the only thing the browser remembers is the result table's
// column filters, as for every table in the UI.
import { useEffect, useState } from "preact/hooks";
import { ApiErrorPanel } from "@hive/shared/api-error-panel.js";
import { readApiError, type ProblemDetails } from "@hive/shared/api-error.js";
@ -19,6 +20,7 @@ import { ClassificationEditor } from "./ClassificationEditor.js";
import { TryOutResult } from "./TryOutResult.js";
import {
draftProblem,
duplicateName,
prNumber,
repoProblem,
toBody,
@ -29,8 +31,9 @@ import "./ReviewTryOutPage.css";
const TRY_OUT = "/api/review-classifier/try-out";
const POLL_MS = 2000;
// More classifications than this are not offered a row; the backend has its
// own cap and says so with a 400, which the page shows as it is.
// More classifications than this are not offered a row. Keep it in step with
// the try-out endpoint's own cap, which answers a longer list with a 400 that
// the page shows as it is; the backend has no way to report it yet.
const MAX_CLASSIFICATIONS = 10;
let nextKey = 0;
@ -115,6 +118,7 @@ export function ReviewTryOutPage() {
repoProblem(repo) ??
(prNumber(pr) === null ? "a PR number is a whole number above 0" : null) ??
drafts.map(draftProblem).find((p) => p !== null) ??
duplicateName(drafts) ??
null;
async function run(e: Event) {