vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Activity

swarm-ui: builds are a card under the job graph on the jobs tab

Browse source 
The builds tab is gone from the nav; its card sits below the jobs card on
/jobs. The swarm-builder commit status now links to /jobs?run=<id>, and the old
/builds address redirects there with its query so links already on PRs still
open the build. Docs and the link test follow.
This commit is contained in:
iris 2026-10-26 20:02:57 +01:00
commit a2f000bab4
10 changed files with 64 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

8
docs/swarm/builder.md
View file

@ -86,10 +86,10 @@ newest 100. Both are behind the swarm UI vhost's `admins` gate, and answer 503
when the controller has no swarm queue or can't open the bucket, 500 when it
can't read it.
The final status links to `https://<swarm domain>/builds?run=<id>`, the swarm
UI's builds page, so selecting **Details** on a red `swarm-builder` check opens
that build's card, with `nix`'s tail, in the browser. The raw record stays at
`GET /api/builder/runs/<id>`. A status has no link when the record wasn't
The final status links to `https://<swarm domain>/jobs?run=<id>`, the swarm
UI's jobs tab, where the builds are a card under the job graph. Selecting
**Details** on a red `swarm-builder` check opens that build's card, with `nix`'s tail, in the browser. The raw record
stays at `GET /api/builder/runs/<id>`. A status has no link when the record wasn't
stored (the controller logs the failed write) or when the controller doesn't
serve the swarm vhost (`SWARM_CONTROLLER_PUBLIC_URL` unset). The `pending`
status has no link.

12
docs/swarm/ui.md
View file

@ -27,13 +27,12 @@ shut. A dropdown inside a dialog opens above the dialog and the dialog doesn't c
| `/agents/<name>/terminal` | one agent's live terminal |
| `/agents/<name>/subagents/<subagent>/terminal` | one of that agent's subagents' live terminal |
| `/alerts` | the alerts the swarm's Grafana holds now: the firing ones, with a button for the pending, no-data and error ones and a link to Grafana's own alert list; read through the controller with a Viewer service-account token |
| `/jobs` | the controller's job graph — where agent creation and credential mints show progress |
| `/jobs` | the controller's job graph, where agent creation and credential mints show progress, and under it the swarm builder's recent builds of agent config PRs, with what nix printed when one failed |
| `/schedules` | the scheduled prompts: add, edit, pause, resume and remove |
| `/messages` | the swarm-wide message feed: every message between agents, and to them from the operator, reminders and compaction, with a history window and a filter on sender or recipient; a folded **broadcast** card above the feed sends one message to more than one agent at once |
| `/notifications` | the notification router's flows: a switch for each built-in, every flow drawn as a graph, and an editor for custom flows |
| `/issues` | a cross-repo issue report |
| `/review` | the review classifier: its recent runs, a try-out on a real PR, and its settings |
| `/builds` | the swarm builder's recent builds of agent config PRs, with what nix printed when one failed |
Everything it shows comes from [`swarm-controller`](../../swarm-controller/README.md).
Pages that refresh on a timer share one polling rule: the page sends no new
@ -473,15 +472,18 @@ previous repo's issues under the error.
### Builds
The **builds** page lists the agent config PR heads the swarm builder built,
The builds sit in a card under the job graph on the **jobs** tab. The old `/builds` address redirects there and keeps its query.
The **builds** card lists the agent config PR heads the swarm builder built,
newest first, from `GET /api/builder/runs`. Each card shows the repo and PR,
the first seven characters of the commit, how the build ended (**built**,
**failed** or **error**), when it started and how long it took. Select a card to
read it: for a failed build, what `nix` printed; for a built one, the system
closure; for an error, why no build came back.
The **Details** link on a `swarm-builder` commit status opens this page as
`/builds?run=<id>`, with that build's card open and in view. The builder keeps
The **Details** link on a `swarm-builder` commit status opens the jobs tab as
`/jobs?run=<id>`, with that build's card open and in view. Links made before the
builds moved, to `/builds?run=<id>`, redirect to the same place. The builder keeps
its newest 100 builds, so a link to an older one shows a note instead.
### Broadcasting a message

13
frontend/packages/swarm-ui/src/App.tsx
View file

@ -1,12 +1,12 @@
// Root shell component — routing only. Each route's content is its own
// page component under `./pages/`; this file just maps paths to them.
import { Route, Router, Switch } from "wouter-preact";
import { Redirect, Route, Router, Switch, useSearch } from "wouter-preact";
import { jobsHref } from "./pages/builds/builds-types.js";
import { Shell } from "./shell/Shell.js";
import { useGuardedLocation } from "./shell/useGuardedLocation.js";
import { AgentsPage } from "./pages/agents/AgentsPage.js";
import { AgentTerminalPage } from "./pages/agents/AgentTerminalPage.js";
import { AlertsPage } from "./pages/AlertsPage.js";
import { BuildsPage } from "./pages/builds/BuildsPage.js";
import { MessagesPage } from "./pages/messages/MessagesPage.js";
import { NEW_FLOW_PATH } from "./pages/notifications/FlowDraft.js";
import { FlowEditorPage } from "./pages/notifications/FlowEditorPage.js";
@ -19,6 +19,13 @@ import { SchedulesPage } from "./pages/schedules/SchedulesPage.js";
import { StartPage } from "./pages/StartPage.js";
import { Panel } from "./ui/panel/Panel.js";
// The builds page moved onto the jobs tab. Links made before that, such as the
// Details link on a swarm-builder commit status, land here and go on to the
// same build's card, query kept.
function BuildsMoved() {
return <Redirect to={jobsHref(useSearch())} replace />;
}
function NotFound() {
return (
<Panel title="404" icon="🧭">
@ -42,7 +49,7 @@ export function App() {
/>
<Route path="/jobs" component={JobsPage} />
<Route path="/schedules" component={SchedulesPage} />
<Route path="/builds" component={BuildsPage} />
<Route path="/builds" component={BuildsMoved} />
<Route path="/messages" component={MessagesPage} />
<Route path="/notifications" component={NotificationsPage} />
<Route path={NEW_FLOW_PATH}>

7
frontend/packages/swarm-ui/src/pages/JobsPage.css
View file

@ -7,3 +7,10 @@
per bundle call). */
@import "@hive/shared/jobq-graph.css";
@import "@hive/shared/jobq-rollup.css";
/* The jobs tab: the job graph's card, then the builds card, one gap apart. */
.ui-jobs-page {
display: flex;
flex-direction: column;
gap: 1em;
}

14
frontend/packages/swarm-ui/src/pages/JobsPage.tsx
View file

@ -22,6 +22,7 @@ import { useState } from "preact/hooks";
import { JobqGraph } from "@hive/shared/jobq-graph.js";
import { JobqRollup } from "@hive/shared/jobq-rollup.js";
import { Panel } from "../ui/panel/Panel.js";
import { BuildsCard } from "./builds/BuildsPage.js";
import {
RefreshIntervalPicker,
useRefreshInterval,
@ -34,7 +35,7 @@ import "./JobsPage.css";
// just solve staleness rather than require an opt-in every visit.
const DEFAULT_INTERVAL_MS: RefreshIntervalMs = 30_000;
export function JobsPage() {
function JobsCard() {
const [intervalMs, setIntervalMs] =
useState<RefreshIntervalMs>(DEFAULT_INTERVAL_MS);
const [refreshToken, setRefreshToken] = useState(0);
@ -66,3 +67,14 @@ export function JobsPage() {
</Panel>
);
}
// The jobs tab holds two cards: the controller's job graph, and the swarm
// builder's recent builds under it.
export function JobsPage() {
return (
<div class="ui-jobs-page">
<JobsCard />
<BuildsCard />
</div>
);
}

10
frontend/packages/swarm-ui/src/pages/builds/BuildsPage.tsx
View file

@ -1,8 +1,10 @@
// <BuildsPage> — the swarm builder's recent builds, newest first: which agent
// <BuildsCard> — the swarm builder's recent builds, newest first: which agent
// config PR heads it built, how each ended, and what `nix` printed when one
// failed. One card per build; selecting a card opens it. Reads
// `GET /api/builder/runs`. A `swarm-builder` commit status links here as
// `/builds?run=<id>`, which opens that build's card and scrolls to it.
// `GET /api/builder/runs`. A `swarm-builder` commit status links to the jobs
// page as `/jobs?run=<id>`, which opens that build's card and scrolls to it.
// The card sits under the job graph on that page; the old `/builds` address
// redirects there with its query.
import { useEffect, useRef, useState } from "preact/hooks";
import { useSearch } from "wouter-preact";
import { ApiErrorPanel } from "@hive/shared/api-error-panel.js";
@ -91,7 +93,7 @@ function BuildCard({
);
}
export function BuildsPage() {
export function BuildsCard() {
const wanted = wantedRun(useSearch());
const [intervalMs, setIntervalMs] =
useState<RefreshIntervalMs>(DEFAULT_INTERVAL_MS);

5
frontend/packages/swarm-ui/src/pages/builds/builds-types.ts
View file

@ -37,6 +37,11 @@ export const OUTCOME_TONE: Record<BuildOutcome, BadgeTone> = {
error: "warning",
};
/** Where an old `/builds` link goes: the jobs page, keeping its query. */
export function jobsHref(search: string): string {
return search === "" ? "/jobs" : `/jobs?${search}`;
}
/** The run a `?run=<id>` query names, or `null` when it names none. */
export function wantedRun(search: string): string | null {
const id = new URLSearchParams(search).get("run");

1
frontend/packages/swarm-ui/src/shell/Shell.tsx
View file

@ -58,7 +58,6 @@ const NAV_ITEMS: { href: string; label: string; accent: string }[] = [
{ href: "/notifications", label: "notifications", accent: "var(--yellow)" },
{ href: "/issues", label: "issues", accent: "var(--yellow)" },
{ href: "/review", label: "review", accent: "var(--amber)" },
{ href: "/builds", label: "builds", accent: "var(--green)" },
{ href: "/components", label: "components", accent: "var(--blue)" },
];

11
frontend/packages/swarm-ui/test/builds-types.test.mjs
View file

@ -3,7 +3,11 @@
// stripping, so the `.ts` module is imported as it is.
import assert from "node:assert/strict";
import { test } from "node:test";
import { bodyText, wantedRun } from "../src/pages/builds/builds-types.ts";
import {
bodyText,
jobsHref,
wantedRun,
} from "../src/pages/builds/builds-types.ts";
const base = {
id: "atlas-abc-1",
@ -49,3 +53,8 @@ test("a run with no text for its outcome shows no body", () => {
assert.equal(bodyText({ ...base, outcome: "failed" }), null);
assert.equal(bodyText({ ...base, outcome: "built", error_tail: "x" }), null);
});
test("an old builds link goes to the jobs page and keeps its query", () => {
assert.equal(jobsHref("run=atlas-abc-1"), "/jobs?run=atlas-abc-1");
assert.equal(jobsHref(""), "/jobs");
});

4
swarm-controller/src/builder.rs
View file

@ -210,7 +210,7 @@ async fn record(
if !builds.record(&build).await {
return None;
}
link_base.map(|base| format!("{}/builds?run={}", base.trim_end_matches('/'), build.id))
link_base.map(|base| format!("{}/jobs?run={}", base.trim_end_matches('/'), build.id))
}
/// A failed node carrying `error`, and the status write's own failure when
@ -349,7 +349,7 @@ mod tests {
assert_eq!((&build.out_path, &build.detail), (&None, &None));
assert!(build.id.starts_with("atlas-abc-"), "{}", build.id);
assert!(build.finished_unix >= build.started_unix);
let link = format!("https://swarm.example/builds?run={}", build.id);
let link = format!("https://swarm.example/jobs?run={}", build.id);
assert_eq!(
written,
[