subagent: say why we refuse an empty --tools, not what one would do
The comments and docs around the empty-`--tools` assert stated a mechanism: that an empty value parses as *unset* and therefore grants MORE built-ins than omitting the flag. That claim came from a measurement, and the installed `claude --help` (2.1.268) says the opposite in as many words — `Use "" to disable all tools`. One of the two is wrong and this repo is not the place that settles it. The rule the code enforces is right under both readings, which is precisely why it should not be argued from either: we never emit an empty `--tools`, because what an empty one means is release-dependent and nothing here wants a subagent with no built-in tools regardless. So the prose now states the rule and the ambiguity, and asserts nothing about `""` in either direction — replacing the claim with its opposite would be the same mistake sourced differently. No behaviour change: the assert, the resolution and every test are untouched. Two test comments also gained the limit they were quietly missing. `no_spawned_tool_escapes_the_session` hardcodes ten names, so it is a canary for tools someone thought to list, not a guarantee — the guarantee is the subset property, which covers tools nobody has invented yet. And `a_subagent_gets_no_builtin_its_parent_lacks` resolves both sides in one process off one env var, so it catches a code divergence but not the two real systemd units disagreeing about `HIVE_TOOL_GROUPS` — which is what they did until the previous commit, and is not a thing a unit test can reach. Refs #4416
This commit is contained in:
parent
4121ccf1f3
commit
9cd30a58ba
3 changed files with 50 additions and 28 deletions
|
|
@ -250,10 +250,15 @@ them — `--dangerously-skip-permissions` had removed the only thing that
|
|||
would have asked, and `--allowedTools` would not have helped: it approves
|
||||
prompts in advance rather than restricting anything.
|
||||
|
||||
One trap worth knowing before editing any of this: an empty `--tools`
|
||||
value parses as _unset_ and grants **more** than omitting the flag, so
|
||||
there is no way to spell "no built-in tools" — the daemon asserts rather
|
||||
than emitting one.
|
||||
One rule worth knowing before editing any of this: **the daemon never
|
||||
emits an empty `--tools` value**, and asserts rather than doing so. Not
|
||||
because of what an empty value does — that's exactly the point. Our own
|
||||
measurement and the installed `claude --help` disagree about whether
|
||||
`--tools ""` means "no tools" or reads as the flag being absent, and the
|
||||
answer belongs to whichever claude release is installed rather than to
|
||||
this repo. Refusing the case is correct under either reading, so the code
|
||||
never has to know which holds. Nothing here wants a subagent with no
|
||||
built-in tools anyway.
|
||||
|
||||
### MCP servers (`--strict-mcp-config`)
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue