Watch
0
0
Fork
You've already forked hyperhive
0

merge_base_of no longer takes open_pulls's doc comment

This commit is contained in:
atlas 2026-10-19 19:51:54 +02:00 • committed by mara
commit 9bbb28731a

View file

@ -105,8 +105,6 @@ pub struct OpenPull {
pub head_sha: Option<String>, pub head_sha: Option<String>,
} }
/// `pulls` as the dropdown's rows, newest (highest number) first. A PR
/// without a usable number cannot be named, so it is left out.
/// The merge base of a PR's head and base branch, read off its commits (the /// The merge base of a PR's head and base branch, read off its commits (the
/// forge lists them from the current head and base): the one parent that is /// forge lists them from the current head and base): the one parent that is
/// not itself a PR commit. `None` when the PR has no commits or its commits /// not itself a PR commit. `None` when the PR has no commits or its commits
@ -130,6 +128,8 @@ fn merge_base_of(commits: &[forgejo_api::structs::Commit]) -> Option<String> {
} }
} }
/// `pulls` as the dropdown's rows, newest (highest number) first. A PR
/// without a usable number cannot be named, so it is left out.
fn open_pulls(pulls: Vec<forgejo_api::structs::PullRequest>) -> Vec<OpenPull> { fn open_pulls(pulls: Vec<forgejo_api::structs::PullRequest>) -> Vec<OpenPull> {
let mut rows: Vec<OpenPull> = pulls let mut rows: Vec<OpenPull> = pulls
.into_iter() .into_iter()