vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

style: drop tracker tags from the collector modules' comments

Browse source 
The pre-push lint refuses them, and rightly: a comment that names an
issue number ages into a pointer at a closed thread. The constraint each
one carried is stated directly instead.
This commit is contained in:
atlas 2026-08-18 13:29:11 +02:00 • committed by mara
commit 98ab0ad59f
2 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
nix/host-modules/otel.nix
View file

@ -230,7 +230,8 @@
# hive whose swarm collector lives elsewhere then names it in # hive whose swarm collector lives elsewhere then names it in
# config instead of needing this file changed. A loopback # config instead of needing this file changed. A loopback
# literal is correct only while listener and caller share a # literal is correct only while listener and caller share a
# netns — the assumption that cost #2860 and #3363. # netns, an assumption that has cost this project two
# outages.
endpoint = config.services.hyperhive.swarm.otel.url; endpoint = config.services.hyperhive.swarm.otel.url;
}; };

9
nix/host-modules/swarm-otel.nix
View file

@ -6,15 +6,16 @@
# - `otel.nix` is the **hive** tier. It receives from this hive's agents # - `otel.nix` is the **hive** tier. It receives from this hive's agents
# on the bridge and forwards, and it holds no upstream credential. # on the bridge and forwards, and it holds no upstream credential.
# - this is the **swarm** tier. It is the only holder of the upstream # - this is the **swarm** tier. It is the only holder of the upstream
# credential, the only writer to the swarm's metrics store, and (once # credential, the only writer to the swarm's metrics store, and the
# #3283 lands) the place that stamps `hive=` from the authenticated # place that will stamp `hive=` from the authenticated connection
# connection rather than from anything a sender can choose. # rather than from anything a sender can choose.
# #
# On a host that runs both, both processes run. They are not collapsed: # On a host that runs both, both processes run. They are not collapsed:
# all-local is a statement about *where* processes run, not about what # all-local is a statement about *where* processes run, not about what
# shape the deployment has, and a local tier boundary that disappears is # shape the deployment has, and a local tier boundary that disappears is
# one the local deployment stops testing. `hive=` attribution is the # one the local deployment stops testing. `hive=` attribution is the
# property that would differ, and it is the one #3283 depends on. # property that would differ, and the ingest auth that makes it
# unforgeable is built on this boundary existing.
# #
# A container rather than a second host unit, for the same reason every # A container rather than a second host unit, for the same reason every
# sibling swarm service is one — and because `services.opentelemetry-collector` # sibling swarm service is one — and because `services.opentelemetry-collector`