vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Activity

hive-forge: subscription --ignore refuses instead of silently watching (#5052)

Browse source
This commit is contained in:
damocles 2026-10-09 11:41:50 +02:00 • committed by mara
commit 902c1ae574
1 changed files with 16 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

21
hive-forge/src/verbs/subscription.rs
View file

@ -21,7 +21,8 @@ pub struct Args {
/// Subscribe (watch the repo). /// Subscribe (watch the repo).
#[arg(long, group = "action")] #[arg(long, group = "action")]
watch: bool, watch: bool,
/// Mute (mark ignored). /// Unsupported: Forgejo's subscription endpoint can't mark a repo
/// ignored without also watching it. Always refuses with an error.
#[arg(long, group = "action")] #[arg(long, group = "action")]
ignore: bool, ignore: bool,
/// Unsubscribe (clear watch + ignore). /// Unsubscribe (clear watch + ignore).
@ -72,12 +73,22 @@ pub fn run(client: &Client, args: Args) -> Result<()> {
println!("unsubscribed"); println!("unsubscribed");
return Ok(()); return Ok(());
} }
if args.watch || args.ignore { if args.ignore {
// Forgejo's PUT subscription endpoint takes no body — it always // Forgejo's PUT subscription endpoint takes no body — it always
// subscribes (watch). The old raw client sent a // subscribes (watch), it has no way to mark a repo ignored
// without also watching it. The old raw client sent a
// `{subscribed, ignored}` body which the server ignored, so // `{subscribed, ignored}` body which the server ignored, so
// `--ignore` has always behaved like `--watch` server-side; the // `--ignore` silently behaved like `--watch` (the opposite of
// typed call just makes that explicit. // what it promises) instead of failing. Refuse instead of lying
// about what happened.
anyhow::bail!(
"subscription --ignore is not supported: Forgejo's subscription \
endpoint has no way to mark a repo ignored without also \
watching it. Use --unwatch to stop watching, or --watch if \
muted-but-watched is what you actually want."
);
}
if args.watch {
let resp = client let resp = client
.api() .api()
.user_current_put_subscription(owner, name) .user_current_put_subscription(owner, name)